A client for Nebula Graph Database that support multi versions #59
Conversation
veezhang
force-pushed
the
ccore
branch
2 times, most recently
from
02270c1 to
ba842f6
Compare
veezhang
changed the title
veezhang
force-pushed
the
ccore
branch
3 times, most recently
from
8e3f57b to
0fc1da0
Compare
ccore/nebula/options.go
Outdated
| return func(o *Options) { | ||
| WithGraphTLS(tlsConfig) | ||
| WithGraphTLS(tlsConfig) | ||
| WithGraphTLS(tlsConfig) |
There was a problem hiding this comment.
Missing WithStorageTLS and WithMetaTLS ?
| Client interface { | ||
| Graph() GraphClient | ||
| Meta() MetaClient | ||
| StorageAdmin() StorageAdminClient |
There was a problem hiding this comment.
can we call storageAdmin storage? for users, they don't know what is storageAdmin, but use it for storage?
There was a problem hiding this comment.
This is named according to thrift define, it is best not to introduce new terms.
|
|
||
| if o.log == nil { | ||
| o.log = defaultOpts.log | ||
| } |
There was a problem hiding this comment.
why don't use if o.log == nil { o.log = noOpLogger{} } instead, don't need define defaultOpts
and check o.version same as o.log?
There was a problem hiding this comment.
Use the same entrance defaultOptions. If this future changes, only defaultOptions need to change.
| V2_0_0 = types.V2_0_0 | ||
| V2_5_0 = types.V2_5_0 | ||
| V2_5_1 = types.V2_5_1 | ||
| V2_6_0 = types.V2_6_0 |
There was a problem hiding this comment.
https://github.com/vesoft-inc/nebula-go/pull/148/files, I see thrift code use 2.6.0, so we need fix this compile bug too, or we use 2.6.1 thrift code instead
| } | ||
|
|
||
| func (c *defaultMetaClient) Close() error { | ||
| return c.meta.open(c.driver) |
ccore/nebula/client_graph.go
Outdated
| } | ||
|
|
||
| func (c *defaultGraphClient) Close() error { | ||
| return c.graph.open(c.driver) |
ccore/nebula/client_storage_admin.go
Outdated
| } | ||
|
|
||
| func (c *defaultStorageAdminClient) Close() error { | ||
| return c.storageAdmin.open(c.driver) |
A client for
Nebula Graph Databasethat support multi versions.Those files in
ccore/nebula/internal/thriftis copy from https://github.com/vesoft-inc/nebula-go .