feat:support cypher parameter #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nianiaJR
reviewed
Dec 28, 2021
service/dao/dao.go
Outdated
| @@ -287,26 +287,29 @@ func Disconnect(nsid string) { | |||
| pool.Disconnect(nsid) | |||
| } | |||
|
|
|||
| func Execute(nsid string, gql string) (result ExecuteResult, err error) { | |||
| func Execute(nsid string, gql string, paramList common.ParameterList) (result ExecuteResult, cmdResult string, err error) { | |||
There was a problem hiding this comment.
cmdResult? what's it like?
nianiaJR
reviewed
Dec 28, 2021
service/pool/pool.go
Outdated
Comment on lines
281
to
356
| if len(request.ParamList) > 0 { | ||
| err = executeCmd(request.ParamList, &connection.parameterMap) | ||
| if err != nil { | ||
| cmdResult = err.Error() | ||
| } else { | ||
| cmdResult = SetParamsSuccess | ||
| } | ||
| } |
There was a problem hiding this comment.
It's like that the cmdResult is not necessary
There was a problem hiding this comment.
If it's error, just return error. The channel response result just return nil, error enough
refactor: remove vscode file update: fix typo value mod: update local cmd mod: update params mod: support params mod: add type
veezhang
reviewed
Dec 29, 2021
service/dao/dao.go
Outdated
| @@ -287,26 +287,30 @@ func Disconnect(nsid string) { | |||
| pool.Disconnect(nsid) | |||
| } | |||
|
|
|||
| func Execute(nsid string, gql string) (result ExecuteResult, err error) { | |||
| func Execute(nsid string, gql string, paramList common.ParameterList) (result ExecuteResult, params common.ParameterMap, err error) { | |||
There was a problem hiding this comment.
Why not put params into ExecuteResult?
veezhang
reviewed
Dec 29, 2021
controllers/db.go
Outdated
Comment on lines
97
to
101
| if len(paramsMap) == 0 { | ||
| res.Params = nil | ||
| } else { | ||
| res.Params = paramsMap | ||
| } |
There was a problem hiding this comment.
The default value of res.Params is nil, need not to assign with nil.
if len(paramsMap) > 0 {
res.Params = paramsMap
}
veezhang
reviewed
Dec 29, 2021
service/pool/pool.go
Outdated
| @@ -12,11 +15,20 @@ import ( | |||
|
|
|||
| uuid "github.com/satori/go.uuid" | |||
| nebula "github.com/vesoft-inc/nebula-go/v2" | |||
| nebulaType "github.com/vesoft-inc/nebula-go/v2/nebula" | |||
There was a problem hiding this comment.
The pkg name alias seems that they are all lowercase, and I haven't seen any uppercase ones.
Use nebulatype instead?
veezhang
reviewed
Dec 29, 2021
service/pool/pool.go
Outdated
Comment on lines
224
to
227
| if reg == nil { | ||
| err = errors.New("invalid regular expression") | ||
| return | ||
| } |
veezhang
reviewed
Dec 29, 2021
| */ | ||
| if len(res) != 2 { | ||
| return | ||
| } else { |
veezhang
reviewed
Dec 29, 2021
service/pool/pool.go
Outdated
Comment on lines
183
to
186
| { | ||
| localCmd = Param | ||
| args = []string{plain} | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.