add meta api #78
Merged
add meta api #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kqzh
commented
Jan 13, 2022
•
kqzh
commented
- ADD HOSTS
- DROP HOSTS
- LIST SPACES
- BALANCE
veezhang
reviewed
Jan 14, 2022
| return nil, err | ||
| } | ||
|
|
||
| return newListSpacesResponseWrapper(resp.Spaces), codeErrorIfHappened(resp.Code, []byte(nthrift.ErrorCodeToName[resp.Code])) |
There was a problem hiding this comment.
Adjust it like this?
if err := codeErrorIfHappened(resp.Code, nil) {
return nil, err
}
return newListSpacesResponseWrapper(resp.Spaces), nil
ccore/nebula/client_meta.go
Outdated
|
|
||
| type ( | ||
| MetaClient interface { | ||
| Open() error | ||
| AddHosts(endpoints []string) error | ||
| DropHosts(endpoints []string) error | ||
| ListSpaces() (types.ListSpacesResponse, error) |
There was a problem hiding this comment.
ListSpaces() ([]types.Space, error) or ListSpaces() ([]types.SpaceList, error)?
ccore/nebula/client_meta.go
Outdated
| AddHosts(endpoints []string) error | ||
| DropHosts(endpoints []string) error | ||
| ListSpaces() (types.ListSpacesResponse, error) | ||
| SubmitJobBalance(space string, endpoints ...string) error |
There was a problem hiding this comment.
Use BalanceData instead? client
How about the client api takes the function as the consideration point, and the driver match the nebula?
veezhang
reviewed
Jan 17, 2022
| @@ -1,7 +1,13 @@ | |||
| package v3_0 | |||
|
|
|||
| import ( | |||
| nerrors "github.com/vesoft-inc/nebula-http-gateway/ccore/nebula/errors" | |||
veezhang
reviewed
Jan 17, 2022
ccore/nebula/types/driver.go
Outdated
Comment on lines
72
to
74
| Spaces interface { | ||
| GetSpaceNames() []string | ||
| } |
There was a problem hiding this comment.
How about define it as:
Space interface {
GetSpaceName() string
}
Spaces []Space
func (s Spaces) GetSpaceNames() []string {
...
}
veezhang
reviewed
Jan 17, 2022
| } | ||
|
|
||
| func (c *defaultMetaClient) Balance(req types.BalanceReq) (types.Balancer, error) { | ||
| return nil, nerrors.ErrUnsupported |
veezhang
reviewed
Jan 17, 2022
|
|
||
| func (c *defaultMetaClient) AddHosts(endpoints []string) error { | ||
| hostsToAdd := make([]*nthrift.HostAddr, 0, len(endpoints)) | ||
| for _, ep := range endpoints { |
There was a problem hiding this comment.
Check it at nebula pkg? And add an func for it?
veezhang
reviewed
Jan 17, 2022
| type BalanceCmd string | ||
|
|
||
| const ( | ||
| BalanceData = BalanceCmd("Balance Data") |
There was a problem hiding this comment.
rename it to balanceData ?
There was a problem hiding this comment.
driver used this, so can't private
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.