Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg/logger: write file first #208

Merged
merged 1 commit into from
May 5, 2022
Merged

pkg/logger: write file first #208

merged 1 commit into from
May 5, 2022

Conversation

veezhang
Copy link
Contributor

@veezhang veezhang commented May 3, 2022

In some cases, stdout write fails, causing logs written to file not to be written, we prefer to ensure logs in file.

@veezhang veezhang requested a review from yixinglu as a code owner May 3, 2022 10:31
@yixinglu yixinglu merged commit 93febd4 into vesoft-inc:master May 5, 2022
@jamieliu1023 jamieliu1023 mentioned this pull request May 7, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yixinglu yixinglu yixinglu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@veezhang @yixinglu