update close() of connection pool to idempotent (#484)

vesoft-inc · Oct 31, 2022 · f4431aa · f4431aa
1 parent 68f18b9
commit f4431aa
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/client/src/main/java/com/vesoft/nebula/client/graph/net/NebulaPool.java b/client/src/main/java/com/vesoft/nebula/client/graph/net/NebulaPool.java
@@ -124,7 +124,9 @@ public boolean init(List<HostAddress> addresses, NebulaPoolConfig config)
      * close the pool, all connections will be closed
      */
     public void close() {
-        checkClosed();
+        if (isClosed.get()) {
+            return;
+        }
         isClosed.set(true);
         this.loadBalancer.close();
         this.objectPool.close();

diff --git a/client/src/main/java/com/vesoft/nebula/client/graph/net/RoundRobinLoadBalancer.java b/client/src/main/java/com/vesoft/nebula/client/graph/net/RoundRobinLoadBalancer.java
@@ -48,7 +48,9 @@ public RoundRobinLoadBalancer(List<HostAddress> addresses, int timeout, SSLParam
     }
 
     public void close() {
-        schedule.shutdownNow();
+        if (!schedule.isShutdown()) {
+            schedule.shutdownNow();
+        }
     }
 
     @Override