Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RoundRobinLoadBalancer enhancement #357

Merged
merged 5 commits into from
Jan 17, 2022
Merged

RoundRobinLoadBalancer enhancement #357

merged 5 commits into from
Jan 17, 2022

Conversation

heziai
Copy link
Contributor

@heziai heziai commented Sep 24, 2021

RoundRobinLoadBalancer enhancements as follows:

  • send yield command as ping, for fail fast
  • use ConcurrentHashMap instead of HashMap, to avoid volatile problem with S_OK or S_BAD

darionyaphet
darionyaphet previously approved these changes Jan 11, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #357 (1d8a18f) into master (e9935d7) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #357      +/-   ##
============================================
+ Coverage     63.58%   63.59%   +0.01%     
  Complexity      729      729              
============================================
  Files            66       66              
  Lines          3444     3445       +1     
  Branches        501      501              
============================================
+ Hits           2190     2191       +1     
  Misses          915      915              
  Partials        339      339              
Impacted Files Coverage Δ
...ebula/client/graph/net/RoundRobinLoadBalancer.java 96.07% <100.00%> (+0.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9935d7...1d8a18f. Read the comment docs.

Copy link
Contributor

@Nicole00 Nicole00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job

@Nicole00 Nicole00 merged commit ad4463b into vesoft-inc:master Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants