Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add version verification #370

Merged
merged 11 commits into from
Oct 19, 2021
Merged

add version verification #370

merged 11 commits into from
Oct 19, 2021

Conversation

klay-ke
Copy link

@klay-ke klay-ke commented Oct 15, 2021

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Oct 15, 2021

Codecov Report

Merging #370 (a664002) into master (fc643c7) will decrease coverage by 0.31%.
The diff coverage is 46.34%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #370      +/-   ##
============================================
- Coverage     62.76%   62.44%   -0.32%     
+ Complexity      631      630       -1     
============================================
  Files            59       60       +1     
  Lines          3024     3049      +25     
  Branches        421      424       +3     
============================================
+ Hits           1898     1904       +6     
- Misses          838      852      +14     
- Partials        288      293       +5     
Impacted Files Coverage Δ
...h/exception/ClientServerIncompatibleException.java 0.00% <0.00%> (ø)
...vesoft/nebula/client/graph/net/ConnObjectPool.java 53.65% <ø> (ø)
...com/vesoft/nebula/client/graph/net/Connection.java 100.00% <ø> (ø)
...com/vesoft/nebula/client/graph/net/NebulaPool.java 91.00% <ø> (ø)
...va/com/vesoft/nebula/client/graph/net/Session.java 45.20% <ø> (ø)
...vesoft/nebula/client/graph/net/SessionWrapper.java 84.61% <ø> (ø)
...esoft/nebula/client/graph/net/SessionsManager.java 56.92% <ø> (ø)
...vesoft/nebula/client/graph/net/SyncConnection.java 50.87% <42.30%> (-2.59%) ⬇️
...java/com/vesoft/nebula/client/meta/MetaClient.java 57.06% <44.44%> (-0.89%) ⬇️
...ebula/client/graph/net/RoundRobinLoadBalancer.java 96.07% <100.00%> (+0.16%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc643c7...a664002. Read the comment docs.

@Nicole00
Copy link
Contributor

The new exception ClientServerIncompatibleException will cause incompatible problem for user's business code.

@klay-ke
Copy link
Author

klay-ke commented Oct 15, 2021

The new exception ClientServerIncompatibleException will cause incompatible problem for user's business code.

the behavior in Java client is the same as python, since python client also throws the exception all the way up to user's

Copy link
Contributor

@Nicole00 Nicole00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@klay-ke klay-ke merged commit 8f1c233 into master Oct 19, 2021
@klay-ke klay-ke deleted the version-verification branch October 19, 2021 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants