-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add version verification #370
Conversation
Codecov Report
@@ Coverage Diff @@
## master #370 +/- ##
============================================
- Coverage 62.76% 62.44% -0.32%
+ Complexity 631 630 -1
============================================
Files 59 60 +1
Lines 3024 3049 +25
Branches 421 424 +3
============================================
+ Hits 1898 1904 +6
- Misses 838 852 +14
- Partials 288 293 +5
Continue to review full report at Codecov.
|
...rc/main/java/com/vesoft/nebula/client/graph/exception/ClientServerIncompatibleException.java
Outdated
Show resolved
Hide resolved
The new exception |
client/src/main/java/com/vesoft/nebula/client/graph/net/NebulaPool.java
Outdated
Show resolved
Hide resolved
the behavior in Java client is the same as python, since python client also throws the exception all the way up to user's |
client/src/main/java/com/vesoft/nebula/client/meta/MetaClient.java
Outdated
Show resolved
Hide resolved
client/src/main/java/com/vesoft/nebula/client/meta/MetaClient.java
Outdated
Show resolved
Hide resolved
client/src/main/java/com/vesoft/nebula/client/graph/net/SyncConnection.java
Outdated
Show resolved
Hide resolved
client/src/main/java/com/vesoft/nebula/client/graph/net/SyncConnection.java
Outdated
Show resolved
Hide resolved
client/src/main/java/com/vesoft/nebula/client/graph/net/Session.java
Outdated
Show resolved
Hide resolved
client/src/main/java/com/vesoft/nebula/client/graph/net/Session.java
Outdated
Show resolved
Hide resolved
client/src/main/java/com/vesoft/nebula/client/graph/net/SessionWrapper.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.