Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update thrift & add config for scan cursor #398

Merged
merged 10 commits into from
Dec 13, 2021
Merged

Conversation

Nicole00
Copy link
Contributor

@Nicole00 Nicole00 commented Dec 7, 2021

No description provided.

@Nicole00 Nicole00 force-pushed the thrift branch 2 times, most recently from dfdfd15 to 896091f Compare December 13, 2021 07:23
@codecov-commenter
Copy link

Codecov Report

Merging #398 (9fe6115) into master (f29e978) will increase coverage by 1.71%.
The diff coverage is 75.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #398      +/-   ##
============================================
+ Coverage     62.27%   63.98%   +1.71%     
- Complexity      686      709      +23     
============================================
  Files            65       65              
  Lines          3337     3343       +6     
  Branches        471      477       +6     
============================================
+ Hits           2078     2139      +61     
+ Misses          955      882      -73     
- Partials        304      322      +18     
Impacted Files Coverage Δ
...com/vesoft/nebula/client/graph/data/ResultSet.java 50.52% <ø> (ø)
.../nebula/client/storage/GraphStorageConnection.java 87.50% <ø> (ø)
.../java/com/vesoft/nebula/encoder/RowWriterImpl.java 43.38% <ø> (ø)
.../com/vesoft/nebula/encoder/SchemaProviderImpl.java 71.95% <ø> (ø)
...nebula/client/storage/scan/ScanResultIterator.java 36.95% <25.00%> (-6.38%) ⬇️
...oft/nebula/client/storage/scan/ScanEdgeResult.java 67.27% <50.00%> (+38.97%) ⬆️
...nebula/client/storage/processor/EdgeProcessor.java 88.63% <86.66%> (-2.80%) ⬇️
...om/vesoft/nebula/client/storage/StorageClient.java 75.25% <100.00%> (+0.25%) ⬆️
...bula/client/storage/processor/VertexProcessor.java 91.89% <100.00%> (+1.26%) ⬆️
...esoft/nebula/client/storage/scan/PartScanInfo.java 66.66% <100.00%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84ddbed...9fe6115. Read the comment docs.

Copy link
Contributor

@jievince jievince left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jievince jievince merged commit 453064d into vesoft-inc:master Dec 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants