-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix host validation to support domain name #436
Conversation
This is a ref for hostname/IP addresses validation: https://gist.github.com/jyeary/d06f9980eb620216ff3a |
28581e8
to
ef1c8ec
Compare
ef1c8ec
to
df82ebf
Compare
Codecov Report
@@ Coverage Diff @@
## master #436 +/- ##
============================================
- Coverage 63.58% 63.25% -0.33%
+ Complexity 730 726 -4
============================================
Files 66 66
Lines 3460 3462 +2
Branches 502 504 +2
============================================
- Hits 2200 2190 -10
- Misses 919 927 +8
- Partials 341 345 +4
Continue to review full report at Codecov.
|
* Fix host validation to support domain name * lint: fixed line length
close: vesoft-inc/nebula-algorithm#42
This validation check only allowed IP format hosts, the domain name
should be supported on both thrift and HostAndPort.
This is blocking the nebula graph in K8s from using spark/java clients.
ref: