Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix host validation to support domain name #436

Merged
merged 2 commits into from
Feb 8, 2022
Merged

Conversation

wey-gu
Copy link
Contributor

@wey-gu wey-gu commented Feb 8, 2022

close: vesoft-inc/nebula-algorithm#42

This validation check only allowed IP format hosts, the domain name
should be supported on both thrift and HostAndPort.

This is blocking the nebula graph in K8s from using spark/java clients.

ref:

@wey-gu wey-gu requested review from jievince and Aiee February 8, 2022 05:41
@wey-gu
Copy link
Contributor Author

wey-gu commented Feb 8, 2022

This is a ref for hostname/IP addresses validation: https://gist.github.com/jyeary/d06f9980eb620216ff3a

@wey-gu wey-gu force-pushed the support-hostname branch 2 times, most recently from 28581e8 to ef1c8ec Compare February 8, 2022 06:07
@codecov-commenter
Copy link

Codecov Report

Merging #436 (df82ebf) into master (176a8f2) will decrease coverage by 0.32%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #436      +/-   ##
============================================
- Coverage     63.58%   63.25%   -0.33%     
+ Complexity      730      726       -4     
============================================
  Files            66       66              
  Lines          3460     3462       +2     
  Branches        502      504       +2     
============================================
- Hits           2200     2190      -10     
- Misses          919      927       +8     
- Partials        341      345       +4     
Impacted Files Coverage Δ
.../vesoft/nebula/client/meta/AbstractMetaClient.java 47.61% <0.00%> (-5.02%) ⬇️
...java/com/vesoft/nebula/client/meta/MetaClient.java 54.18% <0.00%> (-4.93%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 176a8f2...df82ebf. Read the comment docs.

@jievince jievince merged commit c2c9b90 into master Feb 8, 2022
@jievince jievince deleted the support-hostname branch February 8, 2022 06:45
wey-gu added a commit that referenced this pull request Feb 8, 2022
wey-gu added a commit that referenced this pull request Feb 8, 2022
wey-gu added a commit that referenced this pull request Feb 8, 2022
* Fix host validation to support domain name

* lint: fixed line length
Nicole00 pushed a commit that referenced this pull request Feb 10, 2022
* Fix host validation to support domain name

* lint: fixed line length
Nicole00 pushed a commit that referenced this pull request Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support domain name in meta/graph addresses
3 participants