-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent application crash on init time #447
Conversation
I believe it is reasonable to explicitly tell the user if any graphd server is down in the initialization phase, so the user will be notified at an early stage about the problem. What do you think? Update: |
@aminmaghsodi Please check https://github.com/vesoft-inc/nebula-java/runs/5492274297?check_suite_focus=true to fix the lint. |
Done, Thanks @Aiee |
Thanks for your reply and re-consider your belief. If we say nebula graph is designed to be (semi) highly available and scalable, it means there shouldn't be any minor problem affects client, when other components can cover that problem. for example in this problem, when a graphd server is down, another graphd server is present and up in the cluster to cover requests. Consider a situation, when one of graphd services is down at the start time. what is happenning? Actually nothing. because n-1 graphd servers are running. this feature is considered in storaged servers very good. also it is considered in calling graphd service at the runtime. at the start time if some storage servers are down, client does not affect. |
I need an approve. anybody to help? :D |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Good job!
Prevent application crash on init time when less than all graphd servers are available.
In the current version of nebula-java, if any of the graphd servers mentioned in config, is not accessible, the app going to crash.