Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace gopkg.in/yaml.v2 with sigs.k8s.io/yaml #59

Merged
merged 1 commit into from
Sep 11, 2021

Conversation

hezhizhen
Copy link
Contributor

@hezhizhen hezhizhen commented Sep 5, 2021

Since sigs.k8s.io/yaml is widely-used in Kubernetes related projects, I think it's better to use it instead of gopkg.in/yaml.v2.

I also changed the version of k8s.io/kube-scheduler and k8s.io/kubectl.

@CLAassistant
Copy link

CLAassistant commented Sep 5, 2021

CLA assistant check
All committers have signed the CLA.

@wey-gu
Copy link
Contributor

wey-gu commented Sep 6, 2021

Since sigs.k8s.io/yaml is widely-used in Kubernetes related projects, I think it's better to use it instead of gopkg.in/yaml.v2.

I also changed the version of k8s.io/kube-scheduler and k8s.io/kubectl.

👍🏻!! This PR was made in Starbucks, right?
@jamieliu1023

Copy link
Contributor

@MegaByte875 MegaByte875 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants