-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update docs #89
update docs #89
Conversation
doc/user/balance.md
Outdated
Scaling out Storage is divided into two stages. In the first stage, you need to wait for the status of all newly created Pods to be Ready. | ||
|
||
In the second stage, the BALANCE DATA and BALANCE LEADER command is executed. We provide a parameter `enableAutoBalance` in crd to control whether to automatically balance data and leader. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adjust the structure?
For example:
Scaling out Storage is ...
- In the first stage, ...
- In the second stage, ...
We provide ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's need to update config/samples/apps_v1alpha1_nebulacluster.yaml
file ? And helm charts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will update the apps_v1alpha1_nebulacluster.yaml in another pr
doc/user/client_service.md
Outdated
app: nginx-ingress | ||
component: default-backend |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that the traffic will not go to graph?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I'll remove it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it's used to proxy nginx traffic, I think it's useless, we need not to connect it in kubernetes.
doc/user/balance.md
Outdated
Scaling out Storage is divided into two stages. In the first stage, you need to wait for the status of all newly created Pods to be Ready. | ||
|
||
In the second stage, the BALANCE DATA and BALANCE LEADER command is executed. We provide a parameter `enableAutoBalance` in crd to control whether to automatically balance data and leader. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's need to update config/samples/apps_v1alpha1_nebulacluster.yaml
file ? And helm charts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.