Lock requirements versions with pip-tools #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @greyli, thank you for the suggestion, and it seems to be a better practice in Python. Could you please also update the README? |
#152 will update the README. |
Aiee
approved these changes
Nov 9, 2021
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Project requirements should always be locked to prevent the breaking changes introduced from dependencies, and the locked version should be updated periodically.
By the way, I think these requirements should only list dev dependencies, if you agree, I will update them to remove the repeat dependencies that are already defined in the setup.py. Since we normally use the following commands to start to develop the project: