Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace the protocol with header protocol #254

Merged
merged 4 commits into from
Jan 31, 2023

Conversation

Aiee
Copy link
Contributor

@Aiee Aiee commented Jan 4, 2023

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Address vesoft-inc/nebula#5191

Description:

Replace the protocol with header protocol

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

using compact protocol still cause nebula3.Exception.IOErrorException: Header transport frame was too large
protocol = TCompactProtocol.TCompactProtocol(transport)

@codecov-commenter
Copy link

codecov-commenter commented Jan 4, 2023

Codecov Report

Base: 77.45% // Head: 77.61% // Increases project coverage by +0.16% 🎉

Coverage data is based on head (4a2a2b9) compared to base (dde7640).
Patch coverage: 95.45% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #254      +/-   ##
==========================================
+ Coverage   77.45%   77.61%   +0.16%     
==========================================
  Files          18       18              
  Lines        2408     2408              
==========================================
+ Hits         1865     1869       +4     
+ Misses        543      539       -4     
Impacted Files Coverage Δ
nebula3/gclient/net/ConnectionPool.py 93.04% <94.44%> (+1.06%) ⬆️
nebula3/gclient/net/Connection.py 80.50% <100.00%> (+1.69%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@wey-gu
Copy link
Contributor

wey-gu commented Jan 4, 2023

is this related to vesoft-inc/nebula#5190 or other issues actually?

@Aiee
Copy link
Contributor Author

Aiee commented Jan 4, 2023

is this related to vesoft-inc/nebula#5190 or other issues actually?

My bad, I've updated the issue link vesoft-inc/nebula#5191

@wey-gu
Copy link
Contributor

wey-gu commented Jan 10, 2023

is this related to vesoft-inc/nebula#5190 or other issues actually?

My bad, I've updated the issue link vesoft-inc/nebula#5191

Thanks! So with header protocol, the client will not hang but exit in such huge-sized frame cases, right?

@Aiee
Copy link
Contributor Author

Aiee commented Jan 10, 2023

is this related to vesoft-inc/nebula#5190 or other issues actually?

My bad, I've updated the issue link vesoft-inc/nebula#5191

Thanks! So with header protocol, the client will not hang but exit in such huge-sized frame cases, right?

Correct, an exception indicating the frame size is too large will be thrown.

@Nicole00
Copy link
Contributor

storage client also needs consideration.

@Aiee Aiee merged commit ef84e5f into vesoft-inc:master Jan 31, 2023
@Aiee Aiee deleted the update-transport branch January 31, 2023 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants