feat: renew session for expiration, re-execute when error #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wey-gu
force-pushed
the
renew_session_and_reexecute_in_execution_error
branch
3 times, most recently
from
bfb858a to
532e885
Compare
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #306 +/- ##
==========================================
- Coverage 77.83% 77.50% -0.34%
==========================================
Files 18 18
Lines 2423 2485 +62
==========================================
+ Hits 1886 1926 +40
- Misses 537 559 +22 ☔ View full report in Codecov by Sentry. |
Nicole00
reviewed
Jan 8, 2024
wey-gu
force-pushed
the
renew_session_and_reexecute_in_execution_error
branch
2 times, most recently
from
051ecf2 to
e5f4916
Compare
Nicole00
reviewed
Feb 21, 2024
| except ExecutionErrorException as eee: | ||
| retry_count = 0 | ||
| while retry_count < self._retry_times: | ||
| try: |
There was a problem hiding this comment.
sleep before retry execution.
make black happy
addressing review comments by @Nicole00
wey-gu
force-pushed
the
renew_session_and_reexecute_in_execution_error
branch
from
84b7fa1 to
adf40f0
Compare
due to 3.12 setuptools cannot fit >=py3.6.2
Nicole00
approved these changes
Mar 4, 2024
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close: #276
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number: #276
Description:
other changes
CI changed: avoid using pdm install, this was due to since py3.12, future's installation requires setuptools but setuptools was removed and thus it requires explicit installation/dependency on setuptools, while, the setuptools version cannot be resolved in py3.6.2+ actually, so we have to use pip install to mitigate this. (cc @frostming , I replaced pdm install with pip install, ping you to see if elegant way exists?)