Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Note unfinished client. #13

Merged
merged 1 commit into from
Jan 18, 2022
Merged

Note unfinished client. #13

merged 1 commit into from
Jan 18, 2022

Conversation

Shylock-Hg
Copy link
Contributor

No description provided.

@Shylock-Hg Shylock-Hg requested a review from wey-gu January 18, 2022 02:16
wey-gu
wey-gu approved these changes Jan 18, 2022
View reviewed changes
Copy link

@wey-gu wey-gu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@wey-gu
Copy link

wey-gu commented Jan 18, 2022

linting failed?

error: 1 positional argument in format string, but no arguments were given
   --> /home/runner/.cargo/registry/src/github.com-1ecc6299db9ec823/fbthrift-0.0.2/src/simplejson_protocol.rs:540:64
    |
540 |             _ => bail!("Expected [, {{, or \", or number after {}"),
    |                                                                ^^

@Shylock-Hg Shylock-Hg merged commit bed4f6e into vesoft-inc:master Jan 18, 2022
@Shylock-Hg Shylock-Hg deleted the note/unfinished branch January 18, 2022 05:55
@Shylock-Hg
Copy link
Contributor Author

Shylock-Hg commented Jan 18, 2022 •
edited
Loading

linting failed?

error: 1 positional argument in format string, but no arguments were given
   --> /home/runner/.cargo/registry/src/github.com-1ecc6299db9ec823/fbthrift-0.0.2/src/simplejson_protocol.rs:540:64
    |
540 |             _ => bail!("Expected [, {{, or \", or number after {}"),
    |                                                                ^^

It's library code.

@jamieliu1023 jamieliu1023 mentioned this pull request Jan 22, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wey-gu wey-gu wey-gu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Shylock-Hg @wey-gu