Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add python write demo #60

Merged
merged 6 commits into from
Sep 27, 2022
Merged

docs: add python write demo #60

merged 6 commits into from
Sep 27, 2022

Conversation

Reid00
Copy link
Contributor

@Reid00 Reid00 commented Sep 7, 2022

doc effect only

@Reid00 Reid00 mentioned this pull request Sep 7, 2022
Closed
@wey-gu
Copy link
Contributor

wey-gu commented Sep 7, 2022

There is actually vertex write examples in L176, could you please combine your demo example (with edge) in that section?

nebula-spark-connector/README.md

Lines 176 to 188 in dd535bf

### Write in PySpark
Let's try a write example, by default, the `writeMode` is `insert`
```python
df.write.format("com.vesoft.nebula.connector.NebulaDataSource").option(
"type", "vertex").option(
"spaceName", "basketballplayer").option(
"label", "player").option(
"vidPolicy", "").option(
"vertexField", "_vertexId").option(
"batch", 1).option(
"metaAddress", "metad0:9559").option(

@wey-gu wey-gu added the doc affected PR: improvements or additions to documentation label Sep 7, 2022
@Reid00
Copy link
Contributor Author

Reid00 commented Sep 7, 2022

@wey-gu updated.

wey-gu
wey-gu previously approved these changes Sep 7, 2022
View reviewed changes
Copy link
Contributor

@wey-gu wey-gu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks!!!

@wey-gu wey-gu requested a review from Nicole00 September 7, 2022 10:40
Nicole00
Nicole00 reviewed Sep 14, 2022
View reviewed changes
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README_CN.md Outdated Show resolved Hide resolved
README_CN.md Outdated Show resolved Hide resolved
nebula-spark-connector/src/main/scala/com/vesoft/nebula/connector/NebulaOptions.scala Show resolved Hide resolved
@wey-gu
Copy link
Contributor

wey-gu commented Sep 14, 2022

ping @Reid00

@Reid00
Copy link
Contributor Author

Reid00 commented Sep 15, 2022

pls take a look, I update all rankField in README.md

wey-gu
wey-gu approved these changes Sep 15, 2022
View reviewed changes
Copy link
Contributor

@wey-gu wey-gu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!!

@Nicole00 Nicole00 merged commit f78db4c into vesoft-inc:master Sep 27, 2022
@wey-gu wey-gu mentioned this pull request Oct 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nicole00 Nicole00 Nicole00 left review comments

@wey-gu wey-gu wey-gu approved these changes

Assignees
No one assigned
Labels
doc affected PR: improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Reid00 @wey-gu @Nicole00