Skip to content
This repository has been archived by the owner on Dec 1, 2022. It is now read-only.

fix use incorrect lock #500

Merged
merged 2 commits into from
Jun 23, 2021
Merged

fix use incorrect lock #500

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3d4458e
fix use incorrect lock
panda-sheep Jun 22, 2021
877778c
Merge branch 'master' into fix_use_incorrect_lock
critical27 Jun 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/meta/processors/schemaMan/CreateEdgeProcessor.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,11 @@ void CreateEdgeProcessor::process(const cpp2::CreateEdgeReq& req) {
{
// if there is an tag of the same name
// TODO: there exists race condition, we should address it in the future
folly::SharedMutex::ReadHolder rHolder(LockUtils::edgeLock());
folly::SharedMutex::ReadHolder rHolder(LockUtils::tagLock());
auto conflictRet = getTagId(spaceId, edgeName);
if (nebula::ok(conflictRet)) {
LOG(ERROR) << "Failed to create edge `" << edgeName
<< "': some edge with the same name already exists.";
<< "': some tag with the same name already exists.";
resp_.set_id(to(nebula::value(conflictRet), EntryType::EDGE));
handleErrorCode(nebula::cpp2::ErrorCode::E_CONFLICT);
onFinished();
Expand Down