feat: add icon display #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hetao92
reviewed
Sep 29, 2021
| }, | ||
| ); | ||
| if (err) { | ||
| console.error(err); |
nianiaJR
reviewed
Sep 30, 2021
Comment on lines
33
to
50
| <> | ||
| <MenuButton | ||
| tips={!showTitle ? intl.get('common.vertexSets') : undefined} | ||
| component={ | ||
| <VertexDisplay | ||
| showIcon={showIcon} | ||
| handleChangeColorComplete={this.handleChangeColorComplete} | ||
| handleChangeIconComplete={this.handleChangeIconComplete} | ||
| customIcon={customIcon} | ||
| customColor={customColor} | ||
| editing={true} | ||
| /> | ||
| } | ||
| trackCategory="explore" | ||
| trackAction="color_picker" | ||
| trackLabel="from_panel" | ||
| /> | ||
| </> |
nianiaJR
reviewed
Sep 30, 2021
app/assets/config/explore.ts
Outdated
| @@ -222,6 +222,6 @@ export const DEFAULT_EXPLORE_RULES = { | |||
| edgeDirection: 'outgoing', | |||
| stepsType: 'single', | |||
| step: 1, | |||
| vertexColor: 'groupByTag', | |||
| vertexSets: 'groupByTag', | |||
There was a problem hiding this comment.
vertexSets may be not a good name, I don't know what's the meaning of it
There was a problem hiding this comment.
how about vertexStyle? In addition, groupByTag can be more detailed to colorGroupByTag
nianiaJR
reviewed
Sep 30, 2021
| @@ -0,0 +1,55 @@ | |||
| import React from 'react'; | |||
There was a problem hiding this comment.
how about CustomSet to CustomStyle?
|
The suffix of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: add icon display