Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix keyword in schema @common #25

Merged
merged 3 commits into from
Oct 14, 2021
Merged

Conversation

hetao92
Copy link
Contributor

@hetao92 hetao92 commented Oct 12, 2021

fix bug #19

@@ -4,7 +4,7 @@ import _ from 'lodash';
import { keyWords } from '#assets/config/nebulaQL';

export const handleKeyword = (name: string) => {
return keyWords.includes(name) ? '`' + name + '`' : name;
return keyWords.includes(name.toLowerCase()) ? '`' + name + '`' : name;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

return keyWords.includes(name.toLowerCase()) ? `\`${name}\`` : name;

Comment on lines 202 to 204
if (action === 'DROP') {
return name;
return propertyName;
} else {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unnecessary else

Comment on lines +9 to +11
message.config({
maxCount: 1,
});
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it need also in explorer?

Copy link
Contributor

@nianiaJR nianiaJR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hetao92 hetao92 merged commit 92a2e00 into vesoft-inc:master Oct 14, 2021
@hetao92 hetao92 deleted the hetao-dev branch October 14, 2021 06:05
nianiaJR pushed a commit to nianiaJR/nebula-studio that referenced this pull request Dec 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants