feat: update importer version #502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
veezhang
reviewed
Mar 9, 2023
| importconfig "github.com/vesoft-inc/nebula-importer/pkg/config" | ||
| importererrors "github.com/vesoft-inc/nebula-importer/pkg/errors" | ||
| "github.com/vesoft-inc/nebula-importer/v4/pkg/config" | ||
| configbase "github.com/vesoft-inc/nebula-importer/v4/pkg/config/base" |
There was a problem hiding this comment.
Use github.com/vesoft-inc/nebula-importer/v4/pkg/config ?
| } | ||
|
|
||
| task.TaskInfo.TaskStatus = StatusFinished.String() |
There was a problem hiding this comment.
When Stop, it will be executed here. Is this expected?
|
|
||
| importConfig "github.com/vesoft-inc/nebula-importer/v4/pkg/config" |
veezhang
previously approved these changes
Mar 9, 2023
huaxiabuluo
reviewed
Mar 14, 2023
Comment on lines
+21
to
+22
| failedProcessed: number; // The number of nodes and edges that have failed to be processed. | ||
| totalProcessed: number; // The number of nodes and edges that have been processed. |
There was a problem hiding this comment.
/** The number of nodes and edges that have failed to be processed. */
failedProcessed: number;
/** The number of nodes and edges that have been processed. */
totalProcessed: number;
Comment on lines
39
to
46
| data: [], | ||
| activeItem: null, | ||
| previewContent: [], | ||
| // checkAll: false, | ||
| // indeterminate: false, | ||
| checkAll: false, | ||
| indeterminate: false, | ||
| loading: false, | ||
| uploading: false, | ||
| setState: (obj) => Object.assign(state, obj), |
There was a problem hiding this comment.
const localState = useLocalObservable(() => {
const initState = {
......
};
return {
...initState,
setState: (payload: Partial<typeof initState>) => Object.assign(localState, payload),
};
});
Comment on lines
89
to
96
| const refreshTime = () => { | ||
| if(status === ITaskStatus.StatusProcessing) { | ||
| time.current = dayjs.duration(dayjs(Date.now()).diff(dayjs.unix(createTime))).format('HH:mm:ss'); | ||
| time.current = dayjs.duration(dayjs(Date.now()).diff(dayjs(createTime))).format('HH:mm:ss'); | ||
| timeoutId.current = window.setTimeout(refreshTime, 1000); | ||
| } else { | ||
| time.current = dayjs.duration(dayjs.unix(updateTime).diff(dayjs.unix(createTime))).format('HH:mm:ss'); | ||
| time.current = dayjs.duration(dayjs(updateTime).diff(dayjs(createTime))).format('HH:mm:ss'); | ||
| } | ||
| }; |
There was a problem hiding this comment.
trigger per second, but won't cause component rendering
Comment on lines
+131
to
+132
| {processedBytes > 0 && <span> | ||
| {status !== ITaskStatus.StatusFinished && `${getFileSize(processedBytes)} / `} |
huaxiabuluo
approved these changes
Mar 16, 2023
Comment on lines
63
to
69
| const addMsg = () => { | ||
| const info: string[] = []; | ||
| if(numFailed > 0) { | ||
| info.push(intl.get('import.notImported', { total: numFailed })); | ||
| } | ||
| if(numReadFailed > 0) { | ||
| info.push(intl.get('import.readFailed', { total: numReadFailed })); | ||
| if(failedProcessed > 0) { | ||
| info.push(intl.get('import.notImported', { total: failedProcessed })); | ||
| } | ||
| info.length > 0 && setExtraMsg(info.join(', ')); | ||
| }; |
There was a problem hiding this comment.
unnecessary string list
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number:
Description:
How do you solve it?
Special notes for your reviewer, ex. impact of this fix, design document, etc: