Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix issues #534

Merged
merged 2 commits into from
Apr 14, 2023
Merged

fix: fix issues #534

merged 2 commits into from
Apr 14, 2023

Conversation

hetao92
Copy link
Contributor

@hetao92 hetao92 commented Apr 10, 2023

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Description:

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Comment on lines 119 to 120
const newData = data.filter((_, i) => i !== index);
const checkedNum = data.reduce((n, file) => n + (file.withHeader & 1), 0);
const checkedNum = newData.reduce((n, file) => n + (file.withHeader & 1), 0);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

const checkedNum = data.reduce((n, file, i) => n + ((i !== index && file.withHeader) & 1), 0);

Copy link
Contributor

@huaxiabuluo huaxiabuluo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@huaxiabuluo huaxiabuluo merged commit 6c8eab1 into vesoft-inc:master Apr 14, 2023
@hetao92 hetao92 deleted the hetao-fix2 branch April 17, 2023 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants