-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update en-US.json #58
Conversation
Trying to improve some i18n, still need further work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -30,7 +30,7 @@ | |||
"feedback": "Feedback", | |||
"forum": "Help Forum", | |||
"forumLink": "https://discuss.nebula-graph.io/", | |||
"ask": "Sure to do this?", | |||
"ask": "Are you sure to proceed?", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
---> Are you sure you want to proceed?
Are you sure to do means do you ensure the action(to do) instead of what you intend.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @abby-cyber, I think need your expertise to help review/revisit all i18n fields of the studio, I was just trying to do some of them(in the wrong way as you help pointed here ;-) ), would you mind helping when you have the bandwidth to do so?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, sure
}, | ||
"explore": { | ||
"clear": "Clear", | ||
"clearTip": "Whether to clear the graph,are you sure?", | ||
"clearTip": "Are you sure to proceed the cleanup of the renderred graph view?", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto
"outgoing": "Outgoing", | ||
"incoming": "Incoming", | ||
"bidirect": "Bidirect", | ||
"filter": "Custom filter conditions", | ||
"operator": "Operator", | ||
"value": "Value", | ||
"selectSpace": "Please select the space", | ||
"selectReminder": "This will clear the existed graph, are you sure?", | ||
"selectReminder": "The selection of space will cleanup the renderred graph view, are you sure to proceed?", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto
"insertMethodSelect": "Some data on the board. Please select how to insert the new queried results", | ||
"incrementalInsertion": "Incremental Insertion", | ||
"insertAfterClear": "Insert After Clear", | ||
"insertMethodSelect": "How do you like to render the new data with the existing graph view, incrementally or wipe the graph view first?", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"incrementally or wipe the graph view first" sounds a little bit strange here.
do you want to say render incrementally or xxx?
"table": "Table", | ||
"log": "Log", | ||
"record": "Record", | ||
"sorryNGQLCannotBeEmpty": "Sorry, nGQL cannot be empty", | ||
"disablesUseToSwitchSpace": "Disables the use of commands to switch Space", | ||
"NGQLHistoryList": "nGQL History List", | ||
"disablesUseToSwitchSpace": "Switching space from console is not allowed by current role", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Switching space from the Console is not allowed by the current role.
@@ -229,7 +229,7 @@ | |||
"next": "Next", | |||
"goback": "Prev", | |||
"mountPath": "Mount Path", | |||
"importConfigValidationSuccess": "The config validation was successful", | |||
"importConfigValidationSuccess": "The configuration validation was successful", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add .
at the end of the sentence
|
Thank you @abby-cyber , this pr was merged before your comments, allow me to move your comments into a new trackable place an issue: #59 |
Trying to improve some i18n, still need further work.