Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove pwd & input pwd before import data #61

Merged
merged 1 commit into from
Dec 20, 2021

Conversation

hetao92
Copy link
Contributor

@hetao92 hetao92 commented Dec 13, 2021

Copy link
Contributor

@nianiaJR nianiaJR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's conflicted with my token refresh, we need to discuss about it tommor

@@ -137,8 +160,15 @@ class Import extends React.Component<IProps, IState> {
}

const result = data.results?.[0];

if (result?.taskStatus !== 'statusProcessing') {
console.log('result', result);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove

if (result.taskMessage) {
message.warning(result.taskMessage);
}
console.log('status', result.taskStatus);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove

nianiaJR
nianiaJR previously approved these changes Dec 20, 2021
Copy link
Contributor

@nianiaJR nianiaJR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, you can squash the commits && remove the no use console

feat: remove pwd & input pwd before import data

mod: code review
Copy link
Contributor

@nianiaJR nianiaJR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hetao92 hetao92 merged commit 9c7c994 into vesoft-inc:master Dec 20, 2021
@hetao92 hetao92 deleted the hetao-dev branch December 20, 2021 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants