address comments

vesoft-inc · Dec 7, 2022 · 3ced564 · 3ced564
1 parent c96f298
commit 3ced564
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 24 deletions.
diff --git a/src/graph/optimizer/rule/OptimizeLeftJoinPredicateRule.cpp b/src/graph/optimizer/rule/OptimizeLeftJoinPredicateRule.cpp
@@ -151,12 +151,6 @@ StatusOr<OptRule::TransformResult> OptimizeLeftJoinPredicateRule::transform(
   newLeftJoin->setLeftVar(leftJoin->leftInputVar());
   newLeftJoin->setRightVar(newProject->outputVar());
   newLeftJoin->setOutputVar(leftJoin->outputVar());
-  // LOG the col names of newLeftJoin
-  auto& newLeftJoinColNames = newLeftJoin->colNames();
-  LOG(ERROR) << "newLeftJoinColNames.size(): " << newLeftJoinColNames.size();
-  for (auto& colName : newLeftJoinColNames) {
-    LOG(ERROR) << "colName: " << colName;
-  }
   auto* newLeftJoinGroupNode = OptGroupNode::create(octx, newLeftJoin, leftJoinGroup);
   newLeftJoinGroupNode->dependsOn(leftJoinGroupNode->dependencies()[0]);
   newLeftJoinGroupNode->dependsOn(newProjectGroup);

diff --git a/src/graph/optimizer/rule/OptimizeLeftJoinPredicateRule.h b/src/graph/optimizer/rule/OptimizeLeftJoinPredicateRule.h
@@ -9,24 +9,24 @@
 
 namespace nebula {
 namespace opt {
-/* Before:
- *      HashLeftJoin({id(v)}, {id(v)})
- *          /    \
- *       ...    Project
- *        /            \
- *  AppendVertices(v) AppendVertices(v)
- *       /                   \
- *     ...                Traverse(e)
- *
- *  After:
- *     HashLeftJoin({id(v)}, {$-.v})
- *         /    \
- *      ...    Project(..., none_direct_dst(e) AS v)
- *       /            \
- *  AppendVertices(v)  Traverse(e)
- *     /
- *   ...
- */
+// Before:
+//      HashLeftJoin({id(v)}, {id(v)})
+//          |           |
+//         ...       Project
+//          |           |
+//  AppendVertices(v) AppendVertices(v)
+//          |           |
+//         ...       Traverse(e)
+//
+//  After:
+//     HashLeftJoin({id(v)}, {$-.v})
+//         |            |
+//        ...     Project(..., none_direct_dst(e) AS v)
+//         |            |
+//  AppendVertices(v) Traverse(e)
+//         |
+//        ...
+//
 class OptimizeLeftJoinPredicateRule final : public OptRule {
  public:
   const Pattern &pattern() const override;