fix memory leak

vesoft-inc · Dec 3, 2021 · 4afd09b · 4afd09b
1 parent c991256
commit 4afd09b
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/src/storage/mutate/AddEdgesProcessor.cpp b/src/storage/mutate/AddEdgesProcessor.cpp
@@ -219,6 +219,7 @@ void AddEdgesProcessor::doProcessWithIndex(const cpp2::AddEdgesRequest& req) {
         break;
       }
       if (*edgeKey.edge_type_ref() > 0) {
+        std::string oldVal;
         RowReaderWrapper nReader;
         RowReaderWrapper oReader;
         if (!ignoreExistedIndex_) {
@@ -229,8 +230,9 @@ void AddEdgesProcessor::doProcessWithIndex(const cpp2::AddEdgesRequest& req) {
               continue;
             }
             if (!nebula::value(obsIdx).empty()) {
+              oldVal = std::move(value(obsIdx));
               oReader = RowReaderWrapper::getEdgePropReader(
-                  env_->schemaMan_, spaceId_, *edgeKey.edge_type_ref(), nebula::value(obsIdx));
+                  env_->schemaMan_, spaceId_, *edgeKey.edge_type_ref(), oldVal);
             }
           } else {
             code = nebula::error(obsIdx);

diff --git a/src/storage/mutate/AddVerticesProcessor.cpp b/src/storage/mutate/AddVerticesProcessor.cpp
@@ -190,15 +190,17 @@ void AddVerticesProcessor::doProcessWithIndex(const cpp2::AddVerticesRequest& re
 
         RowReaderWrapper nReader;
         RowReaderWrapper oReader;
+        std::string oldVal;
         if (!ignoreExistedIndex_) {
           auto obsIdx = findOldValue(partId, vid, tagId);
           if (nebula::ok(obsIdx)) {
             if (ifNotExists_ && !nebula::value(obsIdx).empty()) {
               continue;
             }
             if (!nebula::value(obsIdx).empty()) {
-              oReader = RowReaderWrapper::getTagPropReader(
-                  env_->schemaMan_, spaceId_, tagId, nebula::value(obsIdx));
+              oldVal = std::move(value(obsIdx));
+              oReader =
+                  RowReaderWrapper::getTagPropReader(env_->schemaMan_, spaceId_, tagId, oldVal);
             }
           } else {
             code = nebula::error(obsIdx);