Add max allowed query size (#2813)

* add max allowed query size
* address comment

conf/nebula-graphd.conf.default

@@ -33,6 +33,8 @@
 # Whether to treat partial success as an error.
 # This flag is only used for Read-only access, and Modify access always treats partial success as an error.
 --accept_partial_success=false
+# Maximum sentence length, unit byte
+--max_allowed_query_size=4194304
 
 ########## networking ##########
 # Comma separated Meta Server Addresses

conf/nebula-graphd.conf.production

@@ -31,6 +31,8 @@
 # Whether to treat partial success as an error.
 # This flag is only used for Read-only access, and Modify access always treats partial success as an error.
 --accept_partial_success=false
+# Maximum sentence length, unit byte
+--max_allowed_query_size=4194304
 
 ########## networking ##########
 # Comma separated Meta Server Addresses

src/graph/service/GraphFlags.cpp

@@ -45,6 +45,7 @@ DEFINE_string(auth_type,
 
 DEFINE_string(cloud_http_url, "", "cloud http url including ip, port, url path");
 DEFINE_uint32(max_allowed_statements, 512, "Max allowed sequential statements");
+DEFINE_uint32(max_allowed_query_size, 4194304, "Max allowed sequential query size");
 
 DEFINE_int64(max_allowed_connections,
  std::numeric_limits<int64_t>::max(),

src/graph/validator/test/QueryValidatorTest.cpp

@@ -8,6 +8,7 @@
 #include "graph/validator/test/ValidatorTestBase.h"
 
 DECLARE_uint32(max_allowed_statements);
+DECLARE_uint32(max_allowed_query_size);
 
 namespace nebula {
 namespace graph {
@@ -1118,6 +1119,26 @@ TEST_F(QueryValidatorTest, TestMaxAllowedStatements) {
  "exceeded");
 }
 
+TEST_F(QueryValidatorTest, TestMaxAllowedQuerySize) {
+ FLAGS_max_allowed_query_size = 256;
+ std::string query = "INSERT VERTEX person(name, age) VALUES ";
+ std::string value = "\"person_1\":(\"person_1\", 1),";
+ int count = (FLAGS_max_allowed_query_size - query.size()) / value.size();
+ std::string values;
+ values.reserve(FLAGS_max_allowed_query_size);
+ for (int i = 0; i < count; ++i) {
+ values.append(value);
+ }
+ values.erase(values.size() - 1);
+ query += values;
+ EXPECT_TRUE(checkResult(query));
+ query.append(",\"person_2\":(\"person_2\", 2);");
+ auto result = checkResult(query);
+ EXPECT_FALSE(result);
+ EXPECT_EQ(std::string(result.message()), "SyntaxError: Query is too large (282 > 256).");
+ FLAGS_max_allowed_query_size = 4194304;
+}
+
 TEST_F(QueryValidatorTest, TestMatch) {
  {
  std::string query =

src/parser/GQLParser.h

@@ -11,6 +11,7 @@
 #include "parser/GraphParser.hpp"
 #include "parser/GraphScanner.h"
 
+DECLARE_uint32(max_allowed_query_size);
 namespace nebula {
 
 class GQLParser {
@@ -39,8 +40,12 @@ class GQLParser {
  }
 
  StatusOr<std::unique_ptr<Sentence>> parse(std::string query) {
- // Since GraphScanner needs a writable buffer, we have to copy the query
- // string
+ // Since GraphScanner needs a writable buffer, we have to copy the query string
+ size_t querySize = query.size();
+ size_t maxAllowedQuerySize = static_cast<size_t>(FLAGS_max_allowed_query_size);
+ if (querySize > maxAllowedQuerySize) {
+ return Status::SyntaxError("Query is too large (%ld > %ld).", querySize, maxAllowedQuerySize);
+ }
  buffer_ = std::move(query);
  pos_ = &buffer_[0];
  end_ = pos_ + buffer_.size();