lookup with dedup (#4651)

* lookup with dedup * fix tck
vesoft-inc · Sep 19, 2022 · c4cd891 · c4cd891
1 parent 9c745d5
commit c4cd891
Show file tree

Hide file tree

Showing 2 changed files with 31 additions and 1 deletion.
diff --git a/src/graph/planner/ngql/LookupPlanner.cpp b/src/graph/planner/ngql/LookupPlanner.cpp
@@ -58,8 +58,11 @@ StatusOr<SubPlan> LookupPlanner::transform(AstContext* astCtx) {
   if (lookupCtx->filter) {
     plan.root = Filter::make(qctx, plan.root, lookupCtx->filter);
   }
-
   plan.root = Project::make(qctx, plan.root, lookupCtx->yieldExpr);
+  if (lookupCtx->dedup) {
+    plan.root = Dedup::make(qctx, plan.root);
+  }
+
   return plan;
 }
 

diff --git a/tests/tck/features/lookup/LookUp.feature b/tests/tck/features/lookup/LookUp.feature
@@ -937,6 +937,33 @@ Feature: LookUpTest_Vid_String
       | '105' |
       | '106' |
       | '121' |
+    When executing query:
+      """
+      LOOKUP ON player where player.age < 100 YIELD player.age as age
+      """
+    Then the result should be, in any order:
+      | age |
+      | 42  |
+      | 36  |
+      | 33  |
+      | 35  |
+      | 28  |
+      | 21  |
+      | 21  |
+      | 20  |
+    When executing query:
+      """
+      LOOKUP ON player where player.age < 100 YIELD distinct player.age as age
+      """
+    Then the result should be, in any order:
+      | age |
+      | 42  |
+      | 36  |
+      | 33  |
+      | 35  |
+      | 28  |
+      | 21  |
+      | 20  |
     When executing query:
       """
       LOOKUP ON player where player.name == "Useless" YIELD id(vertex) as id