Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

is here miss return after err_ = HttpCode::E_ILLEGAL_ARGUMENT; ? #2323

Closed
wadeliuyi opened this issue Aug 26, 2020 · 0 comments
Closed

is here miss return after err_ = HttpCode::E_ILLEGAL_ARGUMENT; ? #2323

wadeliuyi opened this issue Aug 26, 2020 · 0 comments
Assignees
@critical27

Comments

@wadeliuyi
Copy link
Contributor

nebula/src/storage/http/StorageHttpDownloadHandler.cpp

Lines 62 to 66 in 8fec368

auto existStatus = helper_->exist(hdfsHost_, hdfsPort_, hdfsPath_);
if (!existStatus.ok()) {
LOG(ERROR) << "Run Hdfs Test failed. " << existStatus.status().toString();
err_ = HttpCode::E_ILLEGAL_ARGUMENT;
}

@jamieliu1023 jamieliu1023 mentioned this issue Aug 28, 2021
Closed
yixinglu added a commit to yixinglu/nebula that referenced this issue Jan 31, 2023
@nebula-bots @Shylock-Hg @yixinglu
Test/user (vesoft-inc#2323)
3893c79 
* Test/user

* Resolve the conflicts

---------

Co-authored-by: shylock <33566796+Shylock-Hg@users.noreply.github.com>
Co-authored-by: yixinglu <2520865+yixinglu@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@critical27 critical27

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@CPWstatic @critical27 @wadeliuyi