-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimizer rules compatibility #3704
Comments
To avoid these happen again, we could add more test cases which compare the optimized plan. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug (required)
This pr (#3255) should fix all related optimizer rules, because the expression related processing logic has been changed(VarPropertyExpression/InputPropertyExpression -> LabelTagPropertyExpression).
Your Environments (required)
Versions after this pr(#3255)
How To Reproduce(required)
Just check all expression related OptRule code logic.
Additional context
Expression design should be reconsidered
Define the promises to optimizer to avoid errors like this pr
LabelTagProperty
orVarProperty
in this pr)validator
orplanner
setting some context states on which execution plans depend should be disabled)Value
, which is really different from expression rewriting, needs to be disabled or concerned. (eg. ColumnHints design)DataCollect
The text was updated successfully, but these errors were encountered: