enhance same attribute name for different tags #3255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nevermore3
added
do not review
nevermore3
force-pushed
the
add_LabelTagAttributeExpression
branch
4 times, most recently
from
fa692a9
to
c68a152
Compare
nevermore3
changed the title
nevermore3
added
ready-for-testing
Codecov Report
@@ Coverage Diff @@
## master #3255 +/- ##
========================================
Coverage 85.19% 85.20%
========================================
Files 1304 1306 +2
Lines 121308 122289 +981
========================================
+ Hits 103352 104200 +848
- Misses 17956 18089 +133
Continue to review full report at Codecov.
|
CPWstatic
reviewed
Nov 19, 2021
| | [[:like "wang"->"zhang" @0 {likeness: 91}]] | | ||
| When executing query: | ||
| """ | ||
| match p= (v:player)-[e:like]->(d) where v.student.age > 19 return v.student.score, v.student.name, v.player.name |
There was a problem hiding this comment.
Do we support v{.player.name, .student.name}?
There was a problem hiding this comment.
not support right now
There was a problem hiding this comment.
v.{player.name, student.name}
v{.player.name, .student.name}
yixinglu
reviewed
Nov 22, 2021
nevermore3
added
do not review
nevermore3
force-pushed
the
add_LabelTagAttributeExpression
branch
4 times, most recently
from
0b13e85
to
18d4149
Compare
nevermore3
added
ready-for-testing
nevermore3
force-pushed
the
add_LabelTagAttributeExpression
branch
2 times, most recently
from
3923a3b
to
0f5d679
Compare
yixinglu
reviewed
Dec 9, 2021
nevermore3
force-pushed
the
add_LabelTagAttributeExpression
branch
from
b70d257
to
cca7f0f
Compare
CPWstatic
previously approved these changes
Dec 28, 2021
nevermore3
force-pushed
the
add_LabelTagAttributeExpression
branch
from
7450f59
to
ec492a5
Compare
nevermore3
force-pushed
the
add_LabelTagAttributeExpression
branch
from
ec492a5
to
e8065cd
Compare
CPWstatic
approved these changes
Dec 29, 2021
yixinglu
approved these changes
Dec 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
feature
Which issue(s) this PR fixes:
close #xxx
What this PR does / why we need it?
Add tag information when getting the attributes of the vertex,
Special notes for your reviewer, ex. impact of this fix, etc:
Additional context:
Checklist：
Release notes：
Please confirm whether to reflect in release notes and how to describe: