Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

when we drop a tag, drop the index together #4489

Closed
Sophie-Xie opened this issue Aug 5, 2022 · 1 comment
Closed

when we drop a tag, drop the index together #4489

Sophie-Xie opened this issue Aug 5, 2022 · 1 comment
Assignees
@critical27
Labels
type/enhancement Type: make the code neat or more efficient
Milestone
v3.3.0

Comments

@Sophie-Xie
Copy link
Contributor

Sophie-Xie commented Aug 5, 2022 •
edited
Loading

Describe the background of the requirement

  • Why do we need to support this requirement?
    It confuse the user what is the error.
    image
    image

Describe the detail of the requirement

  • Provide a clear and concise description of the requirement.
    When we drop a tag, we should drop the index together.
    Or we should tell the user you should drop the index first.

Describe the scenarios of the requirement

  • If you can, explain some scenarios how users might use this, situations it would be helpful in.
    Every user need this.

from @handsonbao
@Sophie-Xie Sophie-Xie added the type/enhancement Type: make the code neat or more efficient label Aug 5, 2022
@Sophie-Xie Sophie-Xie added this to the v3.3.0 milestone Aug 5, 2022
@Sophie-Xie
Copy link
Contributor Author

When deleting the tag, add an error code, prompting to delete the index first

@wey-gu wey-gu mentioned this issue Aug 6, 2022
Closed
critical27 added a commit to critical27/nebula that referenced this issue Aug 9, 2022
@critical27
fix vesoft-inc#4489
c59f833
@critical27 critical27 mentioned this issue Aug 9, 2022
Merged
11 tasks
Repository owner moved this from Backlog to Done in NebulaGraph v3.3.0 and Tools Aug 16, 2022
@wey-gu wey-gu mentioned this issue Aug 20, 2022
Closed
yixinglu pushed a commit to yixinglu/nebula that referenced this issue Jan 31, 2023
@nebula-bots @critical27
Some minor enhancement (vesoft-inc#1170)
ac0944e 
## What type of PR is this?
- [ ] bug
- [ ] feature
- [X] enhancement

## What problem(s) does this PR solve?
#### Issue(s) number: 
vesoft-inc#4155 
vesoft-inc#4489
vesoft-inc#4497

#### Description:
1. Add more ErrorCode
2. Enhance ErrorCode display in show job 
3. Add a sleep flag to in stats job

Some minor enhancement to do in 3.0, see the related issues.

## How do you solve it?



## Special notes for your reviewer, ex. impact of this fix, design document, etc:



## Checklist:
Tests:
- [X] Unit test(positive and negative cases)
- [ ] Function test
- [ ] Performance test
- [ ] N/A

Affects:
- [ ] Documentation affected (Please add the label if documentation needs to be modified.)
- [ ] Incompatibility (If it breaks the compatibility, please describe it and add the label.）
- [ ] If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
- [ ] Performance impacted: Consumes more CPU/Memory


## Release notes:

Please confirm whether to be reflected in release notes and how to describe:
> ex. Fixed the bug .....


Migrated from vesoft-inc#4500

Co-authored-by: Doodle <13706157+critical27@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@critical27 critical27

Labels
type/enhancement Type: make the code neat or more efficient
Projects
No open projects
NebulaGraph v3.3.0 and Tools
Status: Done
Milestone
v3.3.0
Development

No branches or pull requests
2 participants
@critical27 @Sophie-Xie