Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed enum member UNKNOWN_PROP causing building failurs on thrift. #4986

Closed
xtcyclist opened this issue Dec 5, 2022 · 0 comments · Fixed by #4985
Closed

Removed enum member UNKNOWN_PROP causing building failurs on thrift. #4986

xtcyclist opened this issue Dec 5, 2022 · 0 comments · Fixed by #4985
Assignees
Labels
affects/none PR/issue: this bug affects none version. process/done Process of bug severity/none Severity of bug type/bug Type: something is unexpected

Comments

@xtcyclist
Copy link
Contributor

RT.

enum NullType {
    __NULL__ = 0,
    NaN      = 1,
    BAD_DATA = 2,
    BAD_TYPE = 3,
    ERR_OVERFLOW = 4,
    UNKNOWN_PROP = 5,
    DIV_BY_ZERO = 6,
    OUT_OF_RANGE = 7,
} (cpp.enum_strict, cpp.type = "nebula::NullType")

When UNKNOWN_PROP = 5 was removed, generated thrift codes may not be compiled in some cases.

@xtcyclist xtcyclist added the type/bug Type: something is unexpected label Dec 5, 2022
@xtcyclist xtcyclist self-assigned this Dec 5, 2022
@github-actions github-actions bot added affects/none PR/issue: this bug affects none version. severity/none Severity of bug labels Dec 5, 2022
@github-actions github-actions bot added the process/fixed Process of bug label Dec 5, 2022
@Hester-Gu Hester-Gu added the process/done Process of bug label Jan 13, 2023
@github-actions github-actions bot removed the process/fixed Process of bug label Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects/none PR/issue: this bug affects none version. process/done Process of bug severity/none Severity of bug type/bug Type: something is unexpected
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants