Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added a deprecated marker in common.thrift #4985

Merged

Conversation

xtcyclist
Copy link
Contributor

@xtcyclist xtcyclist commented Dec 5, 2022

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Close #4986
Related to #4907

Description:

Remove a member in an enum may result in generating inconsistent thrift codes and building errors. Not sure what the exact reason is. But keeping the enmu unchanged avoids this risk.

How do you solve it?

  • Add the removed member back (i.e., UNKNOWN_PROP) with a deprecated comment marker.
  • It serves as a placeholder to avoid size differences of enum NullType.
  • It will never be sent to clients, as UNKNOWN_PROP has been removed in Value.h.

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@xtcyclist xtcyclist requested a review from a team as a code owner December 5, 2022 04:03
@xtcyclist xtcyclist added ready-for-testing PR: ready for the CI test ready for review labels Dec 5, 2022
@xtcyclist xtcyclist requested a review from Aiee December 5, 2022 04:06
@xtcyclist xtcyclist added ready-for-testing PR: ready for the CI test and removed ready-for-testing PR: ready for the CI test labels Dec 5, 2022
@xtcyclist xtcyclist merged commit ad34bcd into vesoft-inc:master Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Removed enum member UNKNOWN_PROP causing building failurs on thrift.
3 participants