Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix insert value should put order properties #1215 #1219

Merged
merged 2 commits into from
Nov 16, 2019
Merged

Fix insert value should put order properties #1215 #1219

merged 2 commits into from
Nov 16, 2019

Conversation

laura-ding
Copy link
Contributor

close #1215

@laura-ding laura-ding added the ready-for-testing PR: ready for the CI test label Nov 7, 2019
@laura-ding
Copy link
Contributor Author

jenkins go

@nebula-community-bot
Copy link
Member

Unit testing passed.

@amber-moe amber-moe mentioned this pull request Nov 11, 2019
Closed
dangleptr
dangleptr approved these changes Nov 15, 2019
View reviewed changes
Copy link
Contributor

@dangleptr dangleptr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done! Thanks for taking care of it!

darionyaphet
darionyaphet approved these changes Nov 15, 2019
View reviewed changes
Copy link
Contributor

@darionyaphet darionyaphet left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nebula-community-bot
Copy link
Member

Unit testing passed.

@dangleptr dangleptr merged commit 0bf7fc3 into vesoft-inc:master Nov 16, 2019
yixinglu pushed a commit to yixinglu/nebula that referenced this pull request Feb 16, 2020
@laura-ding @dangleptr
Fix insert value should put order properties vesoft-inc#1215 (vesoft-…
9b49de9 
…inc#1219)
tong-hao pushed a commit to tong-hao/nebula that referenced this pull request Jun 1, 2021
@laura-ding @dangleptr
Fix insert value should put order properties vesoft-inc#1215 (vesoft-…
91913f8 
…inc#1219)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darionyaphet darionyaphet darionyaphet approved these changes

@dangleptr dangleptr dangleptr approved these changes

@CPWstatic CPWstatic Awaiting requested review from CPWstatic

@dutor dutor Awaiting requested review from dutor

@monadbobo monadbobo Awaiting requested review from monadbobo

@zhangguoqing zhangguoqing Awaiting requested review from zhangguoqing

@zlcook zlcook Awaiting requested review from zlcook

Assignees
No one assigned
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Properties order problem when inserting a vertex
5 participants
@laura-ding @nebula-community-bot @darionyaphet @dangleptr @bright-starry-sky