-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add gflags to control max_edge_returned_per_vertex #1221
Conversation
Unit testing failed. |
Unit testing passed. |
src/storage/test/QueryBoundTest.cpp
Outdated
@@ -225,7 +225,9 @@ TEST(QueryBoundTest, OutBoundSimpleTest) { | |||
checkResponse(resp, 30, 12, 10001, 7, true); | |||
} | |||
|
|||
TEST(QueryBoundTest, inBoundSimpleTest) { | |||
TEST(QueryBoundTest, MaxEdgesReturenedTest) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't change the original UT, add a new one.
src/storage/QueryBaseProcessor.cpp
Outdated
@@ -8,6 +8,7 @@ | |||
|
|||
DEFINE_int32(max_handlers_per_req, 10, "The max handlers used to handle one request"); | |||
DEFINE_int32(min_vertices_per_bucket, 3, "The min vertices number in one bucket"); | |||
DEFINE_int32(max_edge_returned_per_vertex, 1000, "The max edge number returnred searching vertex"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The default value should be a bigger one, I'd like it is the maximum of int32. That means we will not cut-off anything by default. And users would config it with an appropriate value in config-file, such as 1000 or 5000, etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx, change to INT_MAX
Unit testing passed. |
Unit testing passed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Unit testing failed. |
Jenkins go |
Unit testing passed. |
* add gflags to control max edge returned from one vertex * rename gflags * fix logic error, from max vertice to max edge * while add new UT, replace an old one by mistake... fix it * change default max edge to INT_MAX
…og-doc * 'glog-doc' of https://github.com/whitewum/nebula: add gflags to control max_edge_returned_per_vertex (vesoft-inc#1221) Fix failed SchemaTest (vesoft-inc#1242) Support to create hard link for current WAL (vesoft-inc#1227) Clear the code associated with AddHosts/RemoveHosts (vesoft-inc#1172) add glog chs
* add gflags to control max edge returned from one vertex * rename gflags * fix logic error, from max vertice to max edge * while add new UT, replace an old one by mistake... fix it * change default max edge to INT_MAX
* doc: add users and cases, optimize format * doc: add users and cases, optimize format for Chinese README Co-authored-by: TommyLemon <tommy.zhou@vesoft.com>
No description provided.