Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Go reversely. #1349

Merged
merged 5 commits into from
Nov 28, 2019
Merged

Go reversely. #1349

merged 5 commits into from
Nov 28, 2019

Conversation

CPWstatic
Copy link
Contributor

Pr #1090 which is submitted by @dutor totally meet our requirements. But we found that there are two things that need to be improved.

  1. We need to save the actual data type when we get data from EdgeHolder.
  2. We need to consider the ranking when we fetch edge props in reversely traversal.

@CPWstatic CPWstatic added the ready-for-testing PR: ready for the CI test label Nov 27, 2019
@CPWstatic
Copy link
Contributor Author

Jenkins go!

@nebula-community-bot
Copy link
Member

Unit testing passed.

laura-ding
laura-ding reviewed Nov 28, 2019
View reviewed changes
src/graph/GoExecutor.cpp Outdated Show resolved Hide resolved
src/graph/GoExecutor.cpp Outdated Show resolved Hide resolved
src/graph/GoExecutor.cpp Outdated Show resolved Hide resolved
src/graph/GoExecutor.cpp Outdated Show resolved Hide resolved
@nebula-community-bot
Copy link
Member

Unit testing passed.

dutor
dutor approved these changes Nov 28, 2019
View reviewed changes
Copy link
Contributor

@dutor dutor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

firing

@nebula-community-bot
Copy link
Member

Unit testing passed.

@dutor dutor merged commit e56fb41 into vesoft-inc:master Nov 28, 2019
This was referenced Nov 28, 2019
Closed
Closed
yixinglu pushed a commit to yixinglu/nebula that referenced this pull request Feb 16, 2020
@CPWstatic @dutor
Go reversely. (vesoft-inc#1349)
58d611d 
* Support go reversely.

* Save column types.

* Get edges with ranking when travese reversely.

* Address comment.
tong-hao pushed a commit to tong-hao/nebula that referenced this pull request Jun 1, 2021
@CPWstatic @dutor
Go reversely. (vesoft-inc#1349)
55c458c 
* Support go reversely.

* Save column types.

* Get edges with ranking when travese reversely.

* Address comment.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dutor dutor dutor approved these changes

@laura-ding laura-ding laura-ding approved these changes

@monadbobo monadbobo Awaiting requested review from monadbobo

@dangleptr dangleptr Awaiting requested review from dangleptr

Assignees
No one assigned
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@CPWstatic @nebula-community-bot @dutor @laura-ding