Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

local conf mode #1411

Merged
merged 3 commits into from
Dec 13, 2019
Merged

local conf mode #1411

merged 3 commits into from
Dec 13, 2019

Conversation

critical27
Copy link
Contributor

@critical27 critical27 commented Dec 10, 2019 •
edited
Loading

  1. For test, we can use local conf instead of use config in meta server.
  2. Support force update configs if user knows exactly what he is doing, so we can update some immutable configs.

e.g. update configs storage:custom_filter_interval_secs=36000 force
Even though custom_filter_interval_secs is a IMMUTABLE config by default, we can still update it with force flag.

close #1375

dangleptr
dangleptr previously approved these changes Dec 10, 2019
View reviewed changes
Copy link
Contributor

@dangleptr dangleptr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done.

@critical27 critical27 added the ready-for-testing PR: ready for the CI test label Dec 10, 2019
@critical27
Copy link
Contributor Author

Jenkins go

@nebula-community-bot
Copy link
Member

Unit testing passed.

dangleptr
dangleptr approved these changes Dec 11, 2019
View reviewed changes
Copy link
Contributor

@dangleptr dangleptr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nebula-community-bot
Copy link
Member

Unit testing passed.

@dangleptr dangleptr merged commit c3e124e into vesoft-inc:master Dec 13, 2019
@dangleptr
Copy link
Contributor

Please update the docs @Amber1990Zhang @critical27

@critical27 critical27 deleted the update-conf branch December 13, 2019 11:31
yixinglu pushed a commit to yixinglu/nebula that referenced this pull request Feb 16, 2020
@critical27 @dangleptr
local conf mode (vesoft-inc#1411)
c1053b5
tong-hao pushed a commit to tong-hao/nebula that referenced this pull request Jun 1, 2021
@critical27 @dangleptr
local conf mode (vesoft-inc#1411)
d7227ad
yixinglu pushed a commit to yixinglu/nebula that referenced this pull request Jan 31, 2023
@Shylock-Hg @Sophie-Xie
Experimental/audit log es batch (vesoft-inc#1411)
abdfe0c 
* Temp commit.

* Fix the es query format.

* Using json content.

* Revert conf.

* Remove debug code.

* Fix test.

* Rollback config.

Co-authored-by: Sophie <84560950+Sophie-Xie@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darionyaphet darionyaphet darionyaphet approved these changes

@dangleptr dangleptr dangleptr approved these changes

@CPWstatic CPWstatic Awaiting requested review from CPWstatic

@jude-zhu jude-zhu Awaiting requested review from jude-zhu

@laura-ding laura-ding Awaiting requested review from laura-ding

@liuyu85cn liuyu85cn Awaiting requested review from liuyu85cn

Assignees
No one assigned
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Takes too much hard disk space
4 participants
@critical27 @nebula-community-bot @dangleptr @darionyaphet