Dump tool. #1479
Merged
Dump tool. #1479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amber-moe
reviewed
Dec 19, 2019
amber-moe
reviewed
Dec 19, 2019
|
Jenkins go! |
|
Unit testing passed. |
|
Unit testing passed. |
CPWstatic
requested review from
dangleptr,
boshengchen,
bright-starry-sky,
critical27,
whitewum and
yixinglu
| } | ||
| } | ||
|
|
||
| std::cout << "===========================STATISTICS============================\n"; |
There was a problem hiding this comment.
why don't use LOG(INFO)
There was a problem hiding this comment.
Why we need log in such a tool?
|
Unit testing failed. |
|
Jenkins go! |
|
Unit testing passed. |
Comment on lines
+170
to
+177
| uint32_t bitmap = | ||
| (parts_.empty() ? 0 : 1 << 3) | ||
| | (vids_.empty() ? 0 : 1 << 2) | ||
| | (tags_.empty() ? 0 : 1 << 1) | ||
| | (edges_.empty() ? 0 : 1); | ||
| switch (bitmap) { | ||
| case 0b0000: { | ||
| // nothing specified,seek to first and print them all |
Comment on lines
+516
to
+521
| auto name = schemaMng_->toTagName(spaceId_, tagId); | ||
| if (!name.ok()) { | ||
| return folly::stringPrintf("%d", tagId); | ||
| } else { | ||
| return name.value(); | ||
| } |
There was a problem hiding this comment.
Aha, A good idea ! Same with a film《Inception》😄
|
Overall, I think this PR is very good ! |
|
Unit testing passed. |
|
Unit testing passed. |
bright-starry-sky
previously approved these changes
Dec 25, 2019
|
close #194 |
Closed
laura-ding
reviewed
Dec 25, 2019
|
close #194 |
laura-ding
previously approved these changes
Dec 27, 2019
bright-starry-sky
previously approved these changes
Dec 27, 2019
|
Unit testing failed. |
CPWstatic
dismissed stale reviews from bright-starry-sky and laura-ding
via
d9fddd2
bright-starry-sky
approved these changes
Dec 27, 2019
|
Unit testing passed. |
Merged
|
Unit testing passed. |
tong-hao
pushed a commit
to tong-hao/nebula
that referenced
this pull request
Jun 1, 2021
* Add dumper. * Add dump. * Add statistics. * Update. * Add to_tag_name. * Rebase and update. * Address @bright-starry-sky's comment. * Address @laura-ding's comment. * Delete FLAGS_load_data_interval_secs. Co-authored-by: bright-starry-sky <56461666+bright-starry-sky@users.noreply.github.com> Co-authored-by: dutor <440396+dutor@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tool is about to help to dump the records or statistics for a space from rocksdb directly. Please take a look about the usage, any suggestion is appreciated.
Example: