Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IF EXISTS support when drop schema. #1505

Merged
merged 8 commits into from
Jan 6, 2020
Merged

Add IF EXISTS support when drop schema. #1505

merged 8 commits into from
Jan 6, 2020

Conversation

Shylock-Hg
Copy link
Contributor

What changes were proposed in this pull request?

#1461

Why are the changes needed?

Add IF EXISTS to drop space/tag/edge.

Does this PR introduce any user-facing change?

Yes.
@Amber1990Zhang Need doc if merged.

How was this patch tested?

UT passed.

@Shylock-Hg Shylock-Hg added the ready-for-testing PR: ready for the CI test label Dec 24, 2019
@amber-moe amber-moe self-assigned this Dec 24, 2019
@Shylock-Hg Shylock-Hg assigned amber-moe and unassigned amber-moe Dec 24, 2019
src/meta/client/MetaClient.h Outdated Show resolved Hide resolved
src/meta/client/MetaClient.h Outdated Show resolved Hide resolved
@nebula-community-bot
Copy link
Member

Unit testing passed.

@nebula-community-bot
Copy link
Member

Unit testing passed.

@nebula-community-bot
Copy link
Member

Unit testing passed.

monadbobo
monadbobo previously approved these changes Dec 26, 2019
Copy link
Contributor

@monadbobo monadbobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@nebula-community-bot
Copy link
Member

Unit testing passed.

Copy link
Contributor

@monadbobo monadbobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@nebula-community-bot
Copy link
Member

Unit testing passed.

@dutor dutor merged commit 013d781 into vesoft-inc:master Jan 6, 2020
tong-hao pushed a commit to tong-hao/nebula that referenced this pull request Jun 1, 2021
* Add `IF EXISTS` support when drop schema.

* Remove the useless const modifier in function declaration.

* Unify symbol to exists.

Co-authored-by: dutor <440396+dutor@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants