change default wal ttl from 1 day to 4 hours.

[whitewum]

What changes were proposed in this pull request?

4 hours wal recycle is enough for most cases.

Why are the changes needed?

wal takes too much ssd disk spaces.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Not necessary.

[critical27]

I suggest change this parameter in storage.conf instead of here, it won't work if we don't update them in console.

[whitewum]

I suggest change this parameter in storage.conf instead of here, it won't work if we don't update them in console.

As far as I know, all the (old) users have changed their conf file, or they are ok with 1 day. So there is no upgrade-and-change-congfigure-file problem.

But for new users, a new parameter is enough.

Why do you prefer parameter (1 day) in the source code?

[critical27]

I suggest change this parameter in storage.conf instead of here, it won't work if we don't update them in console.

As far as I know, all the (old) users have changed their conf file, or they are ok with 1 day. So there is no upgrade-and-change-congfigure-file problem.

But for new users, a new parameter is enough.

Why do you prefer parameter (1 day) in the source code?

After a second thought, I think it's ok to replace it with 4h.

[dangleptr]

The issue has been addressed in #1959
Close it.