Add spec file to build rpm #244
Conversation
|
Unit testing passed. |
package/build_deps.sh
Outdated
| @@ -0,0 +1,10 @@ | |||
| #!/bin/sh | |||
|
|
|||
| # download deps for build nebula | |||
There was a problem hiding this comment.
Should we check the package version as well?
There was a problem hiding this comment.
I had only tested using Federa29 for now, I will test in other system of variant version and check the package version requirements as soon as the experimental envioronment is ready.
package/make_srpm.sh
Outdated
| bindir="$prefix/bin" | ||
| datadir="$prefix/scripts" | ||
| sysconfdir="$prefix/etc" | ||
| version="1.0.0" |
There was a problem hiding this comment.
The version is used in both SRPM and RPM spec. I wonder if we could pull the version out to a central location
There was a problem hiding this comment.
make_srpm.sh will pass the version parameter to nebula.spec. Besides, i think that we could parse version from tag name or user input.
P.S. We need to confirm a version format.
There was a problem hiding this comment.
Sure, sounds good to me. Maybe a TODO comment for now and implement it later
|
|
||
| # download deps | ||
|
|
||
| sudo yum -y install autoconf automake libtool cmake bison unzip boost gperf |
There was a problem hiding this comment.
Same as build_deps.sh, we might want to check the dependents' versions
|
Unit testing failed. |
|
Unit testing passed. |
package/make_srpm.sh
Outdated
| @@ -0,0 +1,65 @@ | |||
| #!/bin/bash | |||
|
|
|||
| # used to build nebula rpm flles | |||
| rpmbuilddir=$OPTARG | ||
| ;; | ||
| ?) echo "Invalid option, use default arguments" | ||
| ;; |
|
Unit testing passed. |
|
Unit testing passed. |
|
|
|
Unit testing passed. |
1 similar comment
|
Unit testing passed. |
* add spec file to build rpm * Address sherman-the-tank's comments * Fix compilation failure * Address steppenwolfyuetong's comments
* add spec file to build rpm * Address sherman-the-tank's comments * Fix compilation failure * Address steppenwolfyuetong's comments
* Remove Common Clause License (vesoft-inc#3263) * Remove Common Clause 1.0 License * Again * Cleanup CC * Remove common clause 1.0 Co-authored-by: Yee <2520865+yixinglu@users.noreply.github.com>
package/build_deps.sh : install deps for build nebula
package/rpm_deps.sh : install deps for rpm
package/make_srpm.sh : the scripts to make rpm packet
package/nebula.spec : the config file for rpmbuild
src/daemons/CMakeLists.txt : add storaged and metad when install