Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Base toss #2525

Merged
merged 11 commits into from
Sep 27, 2021
Merged

Base toss #2525

merged 11 commits into from
Sep 27, 2021

Conversation

liuyu85cn
Copy link
Contributor

@liuyu85cn liuyu85cn commented Aug 16, 2021 •
edited
Loading

This PR is to address this issue that in-edge and out-edge may in-consist while add and update.

I add an upper tier above the normal AddEdgeProcess / UpdateEdgeProcessor.

and I named them Chain...Processor.

spaces who set TOSS on will call those chain processor, and the chain processor will drive the normal ones

to do the actually insert/update.

@liuyu85cn liuyu85cn added the ready-for-testing PR: ready for the CI test label Aug 16, 2021
@liuyu85cn liuyu85cn requested a review from a team August 16, 2021 13:07
@critical27
Copy link
Contributor

Close #2617

@liuyu85cn liuyu85cn force-pushed the base-toss branch 2 times, most recently from bae49d7 to a6e5000 Compare September 16, 2021 09:06
panda-sheep
panda-sheep reviewed Sep 24, 2021
View reviewed changes
Copy link
Contributor

@panda-sheep panda-sheep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A impressive job, which has made our products a big step forward. 👍

panda-sheep
panda-sheep reviewed Sep 26, 2021
View reviewed changes
src/interface/storage.thrift Outdated Show resolved Hide resolved
src/meta/ActiveHostsMan.cpp Outdated Show resolved Hide resolved
src/meta/processors/parts/GetPartsAllocProcessor.cpp Outdated Show resolved Hide resolved
src/meta/processors/parts/GetPartsAllocProcessor.cpp Show resolved Hide resolved
@liuyu85cn liuyu85cn dismissed stale reviews from critical27 and panda-sheep via 60cb19b September 27, 2021 11:32
critical27
critical27 previously approved these changes Sep 27, 2021
View reviewed changes
panda-sheep
panda-sheep previously approved these changes Sep 27, 2021
View reviewed changes
@Sophie-Xie Sophie-Xie added this to the v2.6.0 milestone Sep 27, 2021
@bright-starry-sky
Copy link
Contributor

detected memory leaks

darionyaphet
darionyaphet previously approved these changes Sep 27, 2021
View reviewed changes
Copy link
Contributor

@darionyaphet darionyaphet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

panda-sheep
panda-sheep previously approved these changes Sep 27, 2021
View reviewed changes
@codecov-commenter
Copy link

Codecov Report

Merging #2525 (3013a9f) into master (dddf54e) will decrease coverage by 0.97%.
The diff coverage is 43.41%.

❗ Current head 3013a9f differs from pull request most recent head 93b7987. Consider uploading reports for the commit 93b7987 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2525      +/-   ##
==========================================
- Coverage   85.47%   84.49%   -0.98%     
==========================================
  Files        1229     1250      +21     
  Lines      110375   111719    +1344     
==========================================
+ Hits        94341    94401      +60     
- Misses      16034    17318    +1284
Impacted Files Coverage Δ
src/clients/meta/MetaClient.h 92.30% <ø> (ø)
src/clients/storage/GraphStorageClient.h 100.00% <ø> (ø)
src/clients/storage/InternalStorageClient.cpp 0.00% <0.00%> (ø)
src/clients/storage/InternalStorageClient.h 0.00% <ø> (-100.00%) ⬇️
src/clients/storage/StorageClientBase.h 59.32% <ø> (+6.94%) ⬆️
src/common/utils/NebulaKeyUtils.cpp 89.03% <0.00%> (-4.89%) ⬇️
src/common/utils/NebulaKeyUtils.h 80.68% <ø> (+2.65%) ⬆️
src/graph/executor/mutate/InsertExecutor.cpp 100.00% <ø> (ø)
src/graph/planner/plan/Admin.cpp 54.23% <0.00%> (-2.40%) ⬇️
src/graph/planner/plan/PlanNode.h 80.00% <ø> (ø)
... and 196 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 073fb37...93b7987. Read the comment docs.

@bright-starry-sky bright-starry-sky merged commit cb124f0 into vesoft-inc:master Sep 27, 2021
This was referenced Sep 28, 2021
Closed
Closed
Closed
Closed
@jamieliu1023 jamieliu1023 mentioned this pull request Oct 2, 2021
Closed
@liuyu85cn liuyu85cn deleted the base-toss branch October 8, 2021 02:03
yixinglu pushed a commit to yixinglu/nebula that referenced this pull request Sep 14, 2023
@nebula-bots @xtcyclist
Allow the expressions like 'v.tag' in return (vesoft-inc#2525)
30c357d 
Co-authored-by: Cheng Xuntao <7731943+xtcyclist@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperYoko SuperYoko SuperYoko left review comments

@yixinglu yixinglu yixinglu left review comments

@panda-sheep panda-sheep panda-sheep approved these changes

@darionyaphet darionyaphet darionyaphet approved these changes

@bright-starry-sky bright-starry-sky bright-starry-sky left review comments

@critical27 critical27 critical27 left review comments

@cangfengzhs cangfengzhs Awaiting requested review from cangfengzhs

@liwenhui-soul liwenhui-soul Awaiting requested review from liwenhui-soul

@pengweisong pengweisong Awaiting requested review from pengweisong

Assignees
No one assigned
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Milestone
v2.6.0
Development

Successfully merging this pull request may close these issues.
9 participants
@liuyu85cn @critical27 @panda-sheep @bright-starry-sky @codecov-commenter @yixinglu @darionyaphet @SuperYoko @Sophie-Xie