-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance/fix FileBasedWAL #27
Enhance/fix FileBasedWAL #27
Conversation
sherman-the-tank
commented
Oct 4, 2018
•
edited by dutor
Loading
edited by dutor
- Support log rollback
- Separate buffer flusher logic, so that the number of flushers is independent from the number of WALs/Shards
- Improve the multiple threads support, but still not support multiple threads calling appendLogs()/rollbackToLog()
- Add UT for rollback
- Fix the flaky UTs
Build succeeded. |
1) Support log rollback 2) Separate buffer flusher logic, so that the number of flushers is independent from the number of WALs/Shards 3) Inprove the multiple threads support, but still not support multiple threads calling appendLogs()/rollbackToLog() 4) Add UT for rollback 5) Fix the flaky UTs
Build succeeded. |
@@ -13,7 +13,8 @@ namespace vgraph { | |||
namespace raftex { | |||
|
|||
BufferFlusher::BufferFlusher() | |||
: flushThread_(std::bind(&BufferFlusher::flushLoop, this)) { | |||
: flushThread_("Buffer flusher", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This name is good, but for your reference, thread names in Linux consist of 15 characters at most.
I haven't got an in-depth understanding about the consensus and WAL implementation overall. I shall dig into the details later for myself. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* Enhance/fix FileBasedWAL 1) Support log rollback 2) Separate buffer flusher logic, so that the number of flushers is independent from the number of WALs/Shards 3) Improve the multiple threads support, but still not support multiple threads calling appendLogs()/rollbackToLog() 4) Add UT for rollback 5) Fix the flaky UTs * Rebased and addressed dutor's comments
* Enhance/fix FileBasedWAL 1) Support log rollback 2) Separate buffer flusher logic, so that the number of flushers is independent from the number of WALs/Shards 3) Improve the multiple threads support, but still not support multiple threads calling appendLogs()/rollbackToLog() 4) Add UT for rollback 5) Fix the flaky UTs * Rebased and addressed dutor's comments
Co-authored-by: jievince <38901892+jievince@users.noreply.github.com>