Enhance/fix FileBasedWAL #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
sherman-the-tank
commented
Oct 4, 2018
•
sherman-the-tank
commented
- Support log rollback
- Separate buffer flusher logic, so that the number of flushers is independent from the number of WALs/Shards
- Improve the multiple threads support, but still not support multiple threads calling appendLogs()/rollbackToLog()
- Add UT for rollback
- Fix the flaky UTs
|
Build succeeded. |
dutor
reviewed
Oct 4, 2018
dutor
reviewed
Oct 4, 2018
dutor
reviewed
Oct 4, 2018
dutor
reviewed
Oct 4, 2018
dutor
reviewed
Oct 4, 2018
dutor
reviewed
Oct 4, 2018
dutor
reviewed
Oct 4, 2018
dutor
reviewed
Oct 4, 2018
dutor
reviewed
Oct 4, 2018
1) Support log rollback 2) Separate buffer flusher logic, so that the number of flushers is independent from the number of WALs/Shards 3) Inprove the multiple threads support, but still not support multiple threads calling appendLogs()/rollbackToLog() 4) Add UT for rollback 5) Fix the flaky UTs
|
Build succeeded. |
dutor
reviewed
Oct 8, 2018
| @@ -13,7 +13,8 @@ namespace vgraph { | |||
| namespace raftex { | |||
|
|
|||
| BufferFlusher::BufferFlusher() | |||
| : flushThread_(std::bind(&BufferFlusher::flushLoop, this)) { | |||
| : flushThread_("Buffer flusher", | |||
There was a problem hiding this comment.
This name is good, but for your reference, thread names in Linux consist of 15 characters at most.
|
I haven't got an in-depth understanding about the consensus and WAL implementation overall. I shall dig into the details later for myself. |
yixinglu
pushed a commit
to yixinglu/nebula
that referenced
this pull request
Feb 16, 2020
* Enhance/fix FileBasedWAL 1) Support log rollback 2) Separate buffer flusher logic, so that the number of flushers is independent from the number of WALs/Shards 3) Improve the multiple threads support, but still not support multiple threads calling appendLogs()/rollbackToLog() 4) Add UT for rollback 5) Fix the flaky UTs * Rebased and addressed dutor's comments
tong-hao
pushed a commit
to tong-hao/nebula
that referenced
this pull request
Jun 1, 2021
* Enhance/fix FileBasedWAL 1) Support log rollback 2) Separate buffer flusher logic, so that the number of flushers is independent from the number of WALs/Shards 3) Improve the multiple threads support, but still not support multiple threads calling appendLogs()/rollbackToLog() 4) Add UT for rollback 5) Fix the flaky UTs * Rebased and addressed dutor's comments
yixinglu
pushed a commit
to yixinglu/nebula
that referenced
this pull request
Mar 21, 2022
Co-authored-by: jievince <38901892+jievince@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.