profiling storage detail #2754
Merged
profiling storage detail #2754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
cangfengzhs
commented
Aug 30, 2021
•
cangfengzhs
commented
critical27
reviewed
Sep 9, 2021
cangfengzhs
force-pushed
the
profiling_storage_detail
branch
from
679db39 to
59a3a70
Compare
yixinglu
reviewed
Sep 15, 2021
|
|
||
| AggregateNode(RuntimeContext* context, IterateNode<T>* upstream, EdgeContext* edgeContext) | ||
| : IterateNode<T>(upstream), context_(context), edgeContext_(edgeContext) {} | ||
| : IterateNode<T>(upstream), context_(context), edgeContext_(edgeContext) { | ||
| IterateNode<T>::name_ = "AggregateNode"; |
There was a problem hiding this comment.
I really don't recommend this way to initialize the fields of the base class. Please provide the constructor in the base class to do this, such as:
IterateNode<T>::IterateNode<T>(const std::string& name, ...) : name_(name) {}
AggregateNode(RuntimeContext* context, IterateNode<T>* upstream, EdgeContext* edgeContext)
: IterateNode("AggregateNode", upstream), context_(context)...{}|
|
||
| FetchEdgeNode(RuntimeContext* context, | ||
| EdgeContext* edgeContext, | ||
| EdgeType edgeType, | ||
| const std::vector<PropContext>* props, | ||
| StorageExpressionContext* expCtx = nullptr, | ||
| Expression* exp = nullptr) | ||
| : EdgeNode(context, edgeContext, edgeType, props, expCtx, exp) {} | ||
| : EdgeNode(context, edgeContext, edgeType, props, expCtx, exp) { | ||
| name_ = "FetchEdgeNode"; |
| @@ -44,18 +44,21 @@ class IndexOutputNode final : public RelNode<T> { | |||
| fields_(fields) { | |||
| type_ = context_->isEdge() ? IndexResultType::kEdgeFromIndexScan | |||
| : IndexResultType::kVertexFromIndexScan; | |||
| RelNode<T>::name_ = "IndexOpuputNode"; | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.