Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed fixed_string expression eval for go #2762

Conversation

bright-starry-sky
Copy link
Contributor

@bright-starry-sky bright-starry-sky commented Aug 31, 2021

fixed bug for expression eval when prop data type is fixed_string
Repetition steps:

CREATE SPACE test_space (partition_num=1,replica_factor=1, vid_type=fixed_string(30));
USE test_space
create tag t1(c1 fixed_string(40))
create edge e1(c1 fixed_string(40))
insert vertex t1(c1) values "1":("row"), "2":("row"), "3":("row")
insert edge e1(c1) values "1" -> "2"@0:("row"), "1" -> "3"@0:("row")
go from "1" over e1 where e1.c1 == "row"
go from "1" over e1 where $$.t1.c1 == "row"
go from "1" over e1 where $^.t1.c1 == "row"

@Shylock-Hg Shylock-Hg added the type/bug Type: something is unexpected label Aug 31, 2021
@bright-starry-sky bright-starry-sky added the ready-for-testing PR: ready for the CI test label Aug 31, 2021
@bright-starry-sky bright-starry-sky force-pushed the fix_GetNeighbors_filter_for_vertices branch from 78c3648 to f28161c Compare August 31, 2021 07:10
@CPWstatic CPWstatic requested a review from nevermore3 September 2, 2021 09:50
Copy link
Contributor

@critical27 critical27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bright-starry-sky bright-starry-sky merged commit 84248b0 into vesoft-inc:master Sep 13, 2021
@bright-starry-sky bright-starry-sky deleted the fix_GetNeighbors_filter_for_vertices branch September 13, 2021 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-testing PR: ready for the CI test type/bug Type: something is unexpected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants