Add the time parser. #2770
Closed
Add the time parser. #2770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 15, 2021
Sophie-Xie
requested review from
Aiee and
czpmango
and removed request for
a team
Aiee
reviewed
Sep 17, 2021
| ASSERT_TRUE(result.ok()) << result.status(); | ||
| EXPECT_EQ(nebula::DateTime(2019, 1, 3, 19, 52, 3, 233300), result.value()); | ||
| } | ||
| // lack day |
There was a problem hiding this comment.
Add case for auto result = parser.parseDateTime("2019-01-03T22:22:3.2333Z"); where Z stands for UTC
Sophie-Xie
added
the
need to discuss
|
Refactor by yacc. |
Sophie-Xie
removed
the
need to discuss
…ature/time-parser
|
Refactor in #3179 |
yixinglu
pushed a commit
to yixinglu/nebula
that referenced
this pull request
Sep 14, 2023
* Persist LM resposne * Fix tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #2630
Close #2720