format fetchedges #2779
Merged
format fetchedges #2779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nevermore3
force-pushed
the
format_fetchedges
branch
5 times, most recently
from
517b838 to
1b95198
Compare
|
subjob of #2594 |
Shylock-Hg
reviewed
Sep 22, 2021
Shylock-Hg
reviewed
Sep 22, 2021
nevermore3
force-pushed
the
format_fetchedges
branch
from
41d6a91 to
a617d84
Compare
nevermore3
force-pushed
the
format_fetchedges
branch
4 times, most recently
from
ef94fd8 to
7f5a074
Compare
nevermore3
added
ready-for-testing
nevermore3
force-pushed
the
format_fetchedges
branch
3 times, most recently
from
c360665 to
e2d5779
Compare
Codecov Report
@@ Coverage Diff @@
## master #2779 +/- ##
==========================================
- Coverage 85.47% 84.48% -1.00%
==========================================
Files 1229 1252 +23
Lines 110375 111705 +1330
==========================================
+ Hits 94341 94370 +29
- Misses 16034 17335 +1301
Continue to review full report at Codecov.
|
yixinglu
reviewed
Sep 27, 2021
Shylock-Hg
reviewed
Sep 27, 2021
Shylock-Hg
reviewed
Sep 27, 2021
Shylock-Hg
reviewed
Sep 27, 2021
Shylock-Hg
reviewed
Sep 28, 2021
nevermore3
force-pushed
the
format_fetchedges
branch
from
b27971c to
619005b
Compare
Shylock-Hg
reviewed
Sep 28, 2021
| * attached with Common Clause Condition 1.0, found in the LICENSES directory. | ||
| */ | ||
|
|
||
| #ifndef GRAPH_PLANNER_NGQL_FETCH_EDGES_H_ |
There was a problem hiding this comment.
In my opinion, the effect is the same
There was a problem hiding this comment.
It's the new code style according to the doc.
Shylock-Hg
reviewed
Sep 28, 2021
| @@ -1,4 +1,4 @@ | |||
| /* Copyright (c) 2020 vesoft inc. All rights reserved. | |||
| /* Copyright (c) 2021 vesoft inc. All rights reserved. | |||
Shylock-Hg
reviewed
Sep 28, 2021
| @@ -21,10 +21,10 @@ class FetchEdgesValidatorTest : public ValidatorTestBase { | |||
| }; | |||
|
|
|||
| TEST_F(FetchEdgesValidatorTest, FetchEdgesProp) { | |||
| auto src = VariablePropertyExpression::make(pool_.get(), "_VAR1_", kSrc); | |||
| auto src = ColumnExpression::make(pool_.get(), 0); | |||
There was a problem hiding this comment.
Why change to ColumnExpression?
There was a problem hiding this comment.
Because the column names of the first three columns in the dataset are fixed, we can use columnExpresion instead of VariableProperyExpression
Shylock-Hg
approved these changes
Sep 28, 2021
CPWstatic
approved these changes
Sep 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1、refactor fetch edges
2、support FETCH PROP ON edgeName "A"->"B" YIELD edge AS e, src(edge), dst(edge), rank(edge), type(edge)