Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix slow query test. #2788

Closed
wants to merge 4 commits into from

Conversation

CPWstatic
Copy link
Contributor

The rebuild_index job is rate limited now. This makes the test has to wait for much time.

@CPWstatic CPWstatic added the ready-for-testing PR: ready for the CI test label Sep 2, 2021
Copy link
Contributor

@bright-starry-sky bright-starry-sky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The slow query test case passed. but another test failed. Let's fix them one by one.

newly failed:
test_delete_int_vid_one_vertex_all_tag

@CPWstatic
Copy link
Contributor Author

close #2772

@critical27
Copy link
Contributor

The slow query test case passed. but another test failed. Let's fix them one by one.

newly failed:
test_delete_int_vid_one_vertex_all_tag

There must be something wrong with the tck test framework when rebuild index speed is slower than expected. I guess it won't appear after #2795 merged.

@yixinglu
Copy link
Contributor

yixinglu commented Sep 6, 2021

The slow query test case passed. but another test failed. Let's fix them one by one.
newly failed:
test_delete_int_vid_one_vertex_all_tag

There must be something wrong with the tck test framework when rebuild index speed is slower than expected. I guess it won't appear after #2795 merged.

Even if index rebuilding slow down the whole tests, delete tag should be ok. I think we should find out the cause of the failure

@CPWstatic
Copy link
Contributor Author

Fixed by #2795

@CPWstatic CPWstatic closed this Sep 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants