Correct the yeild var input bug. #2789
Conversation
|
Disable user-defined variables? What does "used inner" mean? |
The variable generated by developer when validating. |
Sophie-Xie
requested review from
czpmango and
nevermore3
and removed request for
a team
nevermore3
added
the
need to discuss
Shylock-Hg
added
the
incompatible
Sophie-Xie
removed
the
need to discuss
| @@ -137,7 +137,10 @@ void DeducePropsVisitor::visit(InputPropertyExpression *expr) { | |||
|
|
|||
| void DeducePropsVisitor::visit(VariablePropertyExpression *expr) { | |||
| exprProps_->insertVarProp(expr->sym(), expr->prop()); | |||
| userDefinedVarNameList_->emplace(expr->sym()); | |||
| if (expr->sym()[0] != '_') { | |||
There was a problem hiding this comment.
What does if (expr->sym()[0] != '_') mean?
There was a problem hiding this comment.
Means variable from query instead of inner generated variable.
There was a problem hiding this comment.
Is there a better alternative implementation.
It's very unfriendly to someone reading this code.
| Scenario: yield constant after pipe | ||
| When executing query: | ||
| """ | ||
| $var = GO FROM "Tim Duncan" OVER *; YIELD $var[0][0] as var00; | ||
| """ | ||
| Then the result should be, in any order: | ||
| | var00 | | ||
| | "Manu Ginobili" | | ||
| | "Manu Ginobili" | | ||
| | "Manu Ginobili" | | ||
| | "Manu Ginobili" | | ||
| | "Manu Ginobili" | | ||
| | "Manu Ginobili" | | ||
| | "Manu Ginobili" | |
There was a problem hiding this comment.
Why is $var[0][0] not one row?
(czp@nebula) [nba]> $var = GO FROM "Tim Duncan" OVER *; YIELD $var[0][0] as var00;
+-----------------+
| var00 |
+-----------------+
| "Manu Ginobili" |
+-----------------+
Got 1 rows (time spent 7942/9138 us)
Mon, 25 Oct 2021 14:11:31 CST
(czp@nebula) [nba]> $var = GO FROM "Tim Duncan" OVER *;
+-----------------+------------+---------------------+
| like._dst | serve._dst | teammate._dst |
+-----------------+------------+---------------------+
| "Manu Ginobili" | | |
+-----------------+------------+---------------------+
| "Tony Parker" | | |
+-----------------+------------+---------------------+
| | "Spurs" | |
+-----------------+------------+---------------------+
| | | "Danny Green" |
+-----------------+------------+---------------------+
| | | "LaMarcus Aldridge" |
+-----------------+------------+---------------------+
| | | "Manu Ginobili" |
+-----------------+------------+---------------------+
| | | "Tony Parker" |
+-----------------+------------+---------------------+
Got 7 rows (time spent 7580/8871 us)
There was a problem hiding this comment.
The result of project keep row count of input variable.
There was a problem hiding this comment.
I understand this, but the inconsistency with the semantics of the statement is confusing to users.
There was a problem hiding this comment.
A little strange. We also could add more input variables to Project to get one row result, but this need discussion.
|
Replace by #3271 |
Close #2495 Close #2646
ps.Maybe I think disable user write variable expression is better, the variable expression just used inner.